Cache refresh may lead to terminal error

[CecileRobertMichon]

clarification: is there a chance for the following happening: cache has not been refreshed -> errors when doing client.List? Asking because, in this case, the error would not be a terminal error.

Originally posted by @shysank in #1697 (comment)

[CecileRobertMichon]

/assign

[CecileRobertMichon]

I have not had a chance to work on this yet, marking it as help wanted in case someone else is able to pick it up.

The ask is to return only return a terminal error when skuCache.Get fails because the SKU doesn't exist. If the skuCache.Get fails because of a cache refresh issue, we should return a regular error, ie. return errors.Wrapf(err, "failed to get SKU %s in compute api", m.AzureMachine.Spec.VMSize).

https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/azure/scope/machine.go#L132

/kind bug
/help

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

I have not had a chance to work on this yet, marking it as help wanted in case someone else is able to pick it up.

The ask is to return only return a terminal error when skuCache.Get fails because the SKU doesn't exist. If the skuCache.Get fails because of a cache refresh issue, we should return a regular error, ie. return errors.Wrapf(err, "failed to get SKU %s in compute api", m.AzureMachine.Spec.VMSize).

https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/azure/scope/machine.go#L132

/kind bug
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.