Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ginkgo version 1.15.2 #1241

Closed
CecileRobertMichon opened this issue Mar 16, 2021 · 2 comments · Fixed by #1247
Closed

Update ginkgo version 1.15.2 #1241

CecileRobertMichon opened this issue Mar 16, 2021 · 2 comments · Fixed by #1247
Assignees
@Evalle
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@CecileRobertMichon
Copy link
Contributor

onsi/ginkgo#780 was fixed in v1.15.2. We should undo the revert to 1.14 and use version 1.15.2.

Version can be updated in the Makefile.

/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

onsi/ginkgo#780 was fixed in v1.15.2. We should undo the revert to 1.14 and use version 1.15.2.

Version can be updated in the Makefile.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 16, 2021
@Evalle
Copy link
Contributor

Evalle commented Mar 17, 2021

/assign

@Evalle Evalle mentioned this issue Mar 17, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evalle Evalle

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-1241: Bump Ginkgo to v1.15.2 Evalle/cluster-api-provider-azure
3 participants
@Evalle @CecileRobertMichon @k8s-ci-robot