Update delete test

kubernetes-sigs · Apr 18, 2022 · faaed62 · faaed62
1 parent 10dc9de
commit faaed62
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/azure/services/scalesets/scalesets.go b/azure/services/scalesets/scalesets.go
@@ -186,6 +186,9 @@ func (s *Service) Delete(ctx context.Context) error {
 
 		// ScaleSet has been deleted
 		s.Scope.DeleteLongRunningOperationState(vmssSpec.Name, serviceName)
+		// Note: we want to handle UpdateDeleteStatus when VMSSExtensions have an error when scalesets become an async service
+		s.Scope.UpdateDeleteStatus(infrav1.BootstrapSucceededCondition, serviceName, nil)
+
 		return nil
 	}
 
@@ -210,6 +213,9 @@ func (s *Service) Delete(ctx context.Context) error {
 
 	// future is either nil, or the result of the future is complete
 	s.Scope.DeleteLongRunningOperationState(vmssSpec.Name, serviceName)
+	// Note: we want to handle UpdateDeleteStatus when VMSSExtensions have an error when scalesets become an async service
+	s.Scope.UpdateDeleteStatus(infrav1.BootstrapSucceededCondition, serviceName, nil)
+
 	return nil
 }
 

diff --git a/azure/services/scalesets/scalesets_test.go b/azure/services/scalesets/scalesets_test.go
@@ -578,7 +578,7 @@ func TestDeleteVMSS(t *testing.T) {
 				m.Get(gomockinternal.AContext(), "my-existing-rg", "my-existing-vmss").
 					Return(compute.VirtualMachineScaleSet{}, autorest.NewErrorWithResponse("", "", &http.Response{StatusCode: 404}, "Not found"))
 				s.DeleteLongRunningOperationState("my-existing-vmss", serviceName)
-				s.UpdatePutStatus(infrav1.BootstrapSucceededCondition, serviceName, nil)
+				s.UpdateDeleteStatus(infrav1.BootstrapSucceededCondition, serviceName, nil)
 			},
 		},
 		{