Skip to content

Commit

Permalink
use outboundlb name as the lb name in cloud config
Browse files Browse the repository at this point in the history
Signed-off-by: Ashutosh Kumar <[email protected]>
  • Loading branch information
sonasingh46 committed Feb 7, 2023
1 parent 03374ec commit b8221b4
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
3 changes: 3 additions & 0 deletions controllers/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ func newCloudProviderConfig(d azure.ClusterScoper) (controlPlaneConfig *CloudPro
SubnetName: subnet.Name,
RouteTableName: subnet.RouteTable.Name,
LoadBalancerSku: "Standard",
LoadBalancerName: d.OutboundLBName(infrav1.Node),
MaximumLoadBalancerRuleCount: 250,
UseManagedIdentityExtension: false,
UseInstanceMetadata: true,
Expand All @@ -279,6 +280,7 @@ func newCloudProviderConfig(d azure.ClusterScoper) (controlPlaneConfig *CloudPro
SubnetName: subnet.Name,
RouteTableName: subnet.RouteTable.Name,
LoadBalancerSku: "Standard",
LoadBalancerName: d.OutboundLBName(infrav1.Node),
MaximumLoadBalancerRuleCount: 250,
UseManagedIdentityExtension: false,
UseInstanceMetadata: true,
Expand Down Expand Up @@ -312,6 +314,7 @@ type CloudProviderConfig struct {
SubnetName string `json:"subnetName"`
RouteTableName string `json:"routeTableName"`
LoadBalancerSku string `json:"loadBalancerSku"`
LoadBalancerName string `json:"loadBalancerName"`
MaximumLoadBalancerRuleCount int `json:"maximumLoadBalancerRuleCount"`
UseManagedIdentityExtension bool `json:"useManagedIdentityExtension"`
UseInstanceMetadata bool `json:"useInstanceMetadata"`
Expand Down
11 changes: 11 additions & 0 deletions controllers/helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -482,6 +483,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -501,6 +503,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true
Expand All @@ -519,6 +522,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true
Expand All @@ -538,6 +542,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true,
Expand All @@ -557,6 +562,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true,
Expand All @@ -578,6 +584,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -598,6 +605,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -618,6 +626,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand All @@ -643,6 +652,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand All @@ -668,6 +678,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand Down

0 comments on commit b8221b4

Please sign in to comment.