Skip to content

Commit

Permalink
Add make verify/test to pre-push pre-commit config
Browse files Browse the repository at this point in the history
This commit adds the same checks run in `make verify` without
duplicating any previous hook runs in pre-commit to the pre-commit
configuration. In addition, this commit adds `make test` to the pre-push
 stage of the pre-commit configuration. This will ensure `verify` and
`test` are successfully passing before the commit is pushed. This will
help reduce time and test resources by preventing `verify` and `test`
from failing on the pull request in GitHub.

Signed-off-by: Bryan Cox <[email protected]>
  • Loading branch information
bryan-cox committed Dec 6, 2024
1 parent b596029 commit b33199c
Showing 1 changed file with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,35 @@ repos:
hooks:
- id: forbid-binary
stages: [pre-commit]
- repo: local
hooks:
- id: make-modules
name: Run make verify-modules
entry: make verify-modules
language: system
stages: [pre-push]
- id: make-gen
name: Run make verify-gen
entry: make verify-gen
language: system
stages: [pre-push]
- id: make-spellcheck
name: Run make verify-shellcheck
entry: make verify-shellcheck
language: system
stages: [ pre-push ]
- id: make-conversions
name: Run make verify-conversions
entry: make verify-conversions
language: system
stages: [ pre-push ]
- id: make-tiltfile
name: Run make verify-tiltfile
entry: make verify-tiltfile
language: system
stages: [ pre-push ]
- id: make-test
name: Run make test
entry: make test
language: system
stages: [pre-push]

0 comments on commit b33199c

Please sign in to comment.