Add validate create test

kubernetes-sigs · Feb 27, 2023 · 907f361 · 907f361
1 parent f6c05d5
commit 907f361
Showing 1 changed file with 87 additions and 1 deletion.
diff --git a/api/v1beta1/azuremanagedcontrolplanetemplate_webhook_test.go b/api/v1beta1/azuremanagedcontrolplanetemplate_webhook_test.go
@@ -20,10 +20,63 @@ import (
 	"testing"
 
 	. "github.com/onsi/gomega"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	utilfeature "k8s.io/component-base/featuregate/testing"
 	"k8s.io/utils/pointer"
+	"sigs.k8s.io/cluster-api-provider-azure/feature"
+	capifeature "sigs.k8s.io/cluster-api/feature"
 )
 
-func TestAzureManagedControlPlaneTemplateTemplateValidateUpdate(t *testing.T) {
+func TestAzureManagedControlPlaneTemplate_ValidateCreate(t *testing.T) {
+	// NOTE: AzureManageControlPlaneTemplate is behind AKS feature gate flag; the webhook
+	// must prevent creating new objects in case the feature flag is disabled.
+	defer utilfeature.SetFeatureGateDuringTest(t, feature.Gates, capifeature.MachinePool, true)()
+	g := NewWithT(t)
+
+	tests := []struct {
+		name    string
+		amcpt   *AzureManagedControlPlaneTemplate
+		wantErr bool
+	}{
+		{
+			name:    "all valid",
+			amcpt:   getKnownValidAzureManagedControlPlaneTemplate(),
+			wantErr: false,
+		},
+		{
+			name:    "invalid DNSServiceIP",
+			amcpt:   createAzureManagedControlPlaneTemplate(metav1.ObjectMeta{}, "192.168.0.0.3", "v1.18.0"),
+			wantErr: true,
+		},
+		{
+			name:    "invalid version",
+			amcpt:   createAzureManagedControlPlaneTemplate(metav1.ObjectMeta{}, "192.168.0.0", "honk.version"),
+			wantErr: true,
+		},
+		{
+			name:    "invalid name with microsoft",
+			amcpt:   createAzureManagedControlPlaneTemplate(metav1.ObjectMeta{Name: "microsoft-cluster"}, "192.168.0.0", "v1.18.0"),
+			wantErr: true,
+		},
+		{
+			name:    "invalid name with windows",
+			amcpt:   createAzureManagedControlPlaneTemplate(metav1.ObjectMeta{Name: "a-windows-cluster"}, "192.168.0.0", "v1.18.0"),
+			wantErr: true,
+		},
+	}
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			err := tc.amcpt.ValidateCreate(nil)
+			if tc.wantErr {
+				g.Expect(err).To(HaveOccurred())
+			} else {
+				g.Expect(err).NotTo(HaveOccurred())
+			}
+		})
+	}
+}
+
+func TestAzureManagedControlPlaneTemplate_ValidateUpdate(t *testing.T) {
 
 	oldManagedControlPlaneTemplate := &AzureManagedControlPlaneTemplate{
 		Spec: AzureManagedControlPlaneTemplateSpec{
@@ -50,3 +103,36 @@ func TestAzureManagedControlPlaneTemplateTemplateValidateUpdate(t *testing.T) {
 		g.Expect(newManagedControlPlaneTemplate.ValidateUpdate(oldManagedControlPlaneTemplate, nil)).NotTo(Succeed())
 	})
 }
+
+func createAzureManagedControlPlaneTemplate(objectMeta metav1.ObjectMeta, serviceIP, version string) *AzureManagedControlPlaneTemplate {
+	return &AzureManagedControlPlaneTemplate{
+		ObjectMeta: objectMeta,
+		Spec: AzureManagedControlPlaneTemplateSpec{
+			Template: AzureManagedControlPlaneTemplateResource{
+				Spec: AzureManagedControlPlaneTemplateResourceSpec{
+					DNSServiceIP: pointer.String(serviceIP),
+					Version:      version,
+				},
+			},
+		},
+	}
+}
+
+func getKnownValidAzureManagedControlPlaneTemplate() *AzureManagedControlPlaneTemplate {
+	return &AzureManagedControlPlaneTemplate{
+		Spec: AzureManagedControlPlaneTemplateSpec{
+			Template: AzureManagedControlPlaneTemplateResource{
+				Spec: AzureManagedControlPlaneTemplateResourceSpec{
+					DNSServiceIP: pointer.String("192.168.0.0"),
+					Version:      "v1.18.0",
+					AADProfile: &AADProfile{
+						Managed: true,
+						AdminGroupObjectIDs: []string{
+							"616077a8-5db7-4c98-b856-b34619afg75h",
+						},
+					},
+				},
+			},
+		},
+	}
+}