Merge pull request #2917 from nojnhuh/e2e-aks-tags

add e2e test for AKS resource tag operations

test/e2e/aks_tags.go

@@ -0,0 +1,185 @@
+//go:build e2e
+// +build e2e
+
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package e2e
+
+import (
+	"context"
+	"sync"
+
+	"github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2021-05-01/containerservice"
+	"github.com/Azure/go-autorest/autorest/azure/auth"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	"k8s.io/apimachinery/pkg/types"
+	infrav1 "sigs.k8s.io/cluster-api-provider-azure/api/v1beta1"
+	"sigs.k8s.io/cluster-api-provider-azure/azure/converters"
+	infrav1exp "sigs.k8s.io/cluster-api-provider-azure/exp/api/v1beta1"
+	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
+	expv1 "sigs.k8s.io/cluster-api/exp/api/v1beta1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+type AKSAdditionalTagsSpecInput struct {
+	Cluster       *clusterv1.Cluster
+	MachinePools  []*expv1.MachinePool
+	WaitForUpdate []interface{}
+}
+
+func AKSAdditionalTagsSpec(ctx context.Context, inputGetter func() AKSAdditionalTagsSpecInput) {
+	input := inputGetter()
+
+	settings, err := auth.GetSettingsFromEnvironment()
+	Expect(err).NotTo(HaveOccurred())
+	subscriptionID := settings.GetSubscriptionID()
+	auth, err := settings.GetAuthorizer()
+	Expect(err).NotTo(HaveOccurred())
+
+	managedclustersClient := containerservice.NewManagedClustersClient(subscriptionID)
+	managedclustersClient.Authorizer = auth
+
+	agentpoolsClient := containerservice.NewAgentPoolsClient(subscriptionID)
+	agentpoolsClient.Authorizer = auth
+
+	mgmtClient := bootstrapClusterProxy.GetClient()
+	Expect(mgmtClient).NotTo(BeNil())
+
+	infraControlPlane := &infrav1exp.AzureManagedControlPlane{}
+	err = mgmtClient.Get(ctx, client.ObjectKey{
+		Namespace: input.Cluster.Spec.ControlPlaneRef.Namespace,
+		Name:      input.Cluster.Spec.ControlPlaneRef.Name,
+	}, infraControlPlane)
+	Expect(err).NotTo(HaveOccurred())
+
+	var wg sync.WaitGroup
+
+	wg.Add(1)
+	go func() {
+		defer GinkgoRecover()
+		defer wg.Done()
+
+		var expectedTags infrav1.Tags
+		checkTags := func(g Gomega) {
+			managedcluster, err := managedclustersClient.Get(ctx, infraControlPlane.Spec.ResourceGroupName, infraControlPlane.Name)
+			g.Expect(err).NotTo(HaveOccurred())
+			actualTags := converters.MapToTags(managedcluster.Tags)
+			if expectedTags == nil {
+				g.Expect(actualTags).To(BeNil())
+			} else {
+				g.Expect(actualTags).To(Equal(expectedTags))
+			}
+		}
+
+		By("Deleting all tags for control plane")
+		expectedTags = nil
+		Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(infraControlPlane), infraControlPlane)).To(Succeed())
+		initialTags := infraControlPlane.Spec.AdditionalTags
+		infraControlPlane.Spec.AdditionalTags = expectedTags
+		Expect(mgmtClient.Update(ctx, infraControlPlane)).To(Succeed())
+		Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+
+		By("Creating tags for control plane")
+		expectedTags = infrav1.Tags{
+			"test":    "tag",
+			"another": "value",
+		}
+		Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(infraControlPlane), infraControlPlane)).To(Succeed())
+		infraControlPlane.Spec.AdditionalTags = expectedTags
+		Expect(mgmtClient.Update(ctx, infraControlPlane)).To(Succeed())
+		Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+
+		By("Updating tags for control plane")
+		expectedTags["test"] = "updated"
+		delete(expectedTags, "another")
+		expectedTags["new"] = "value"
+		Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(infraControlPlane), infraControlPlane)).To(Succeed())
+		infraControlPlane.Spec.AdditionalTags = expectedTags
+		Expect(mgmtClient.Update(ctx, infraControlPlane)).To(Succeed())
+		Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+
+		By("Restoring initial tags for control plane")
+		expectedTags = initialTags
+		Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(infraControlPlane), infraControlPlane)).To(Succeed())
+		infraControlPlane.Spec.AdditionalTags = expectedTags
+		Expect(mgmtClient.Update(ctx, infraControlPlane)).To(Succeed())
+		Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+	}()
+
+	for _, mp := range input.MachinePools {
+		wg.Add(1)
+		go func(mp *expv1.MachinePool) {
+			defer GinkgoRecover()
+			defer wg.Done()
+
+			ammp := &infrav1exp.AzureManagedMachinePool{}
+			Expect(mgmtClient.Get(ctx, types.NamespacedName{
+				Namespace: mp.Spec.Template.Spec.InfrastructureRef.Namespace,
+				Name:      mp.Spec.Template.Spec.InfrastructureRef.Name,
+			}, ammp)).To(Succeed())
+
+			var expectedTags infrav1.Tags
+			checkTags := func(g Gomega) {
+				agentpool, err := agentpoolsClient.Get(ctx, infraControlPlane.Spec.ResourceGroupName, infraControlPlane.Name, *ammp.Spec.Name)
+				g.Expect(err).NotTo(HaveOccurred())
+				actualTags := converters.MapToTags(agentpool.Tags)
+				if expectedTags == nil {
+					g.Expect(actualTags).To(BeNil())
+				} else {
+					g.Expect(actualTags).To(Equal(expectedTags))
+				}
+			}
+
+			Byf("Deleting all tags for machine pool %s", mp.Name)
+			expectedTags = nil
+			Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(ammp), ammp)).To(Succeed())
+			initialTags := ammp.Spec.AdditionalTags
+			ammp.Spec.AdditionalTags = expectedTags
+			Expect(mgmtClient.Update(ctx, ammp)).To(Succeed())
+			Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+
+			Byf("Creating tags for machine pool %s", mp.Name)
+			expectedTags = infrav1.Tags{
+				"test":    "tag",
+				"another": "value",
+			}
+			Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(ammp), ammp)).To(Succeed())
+			ammp.Spec.AdditionalTags = expectedTags
+			Expect(mgmtClient.Update(ctx, ammp)).To(Succeed())
+			Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+
+			Byf("Updating tags for machine pool %s", mp.Name)
+			expectedTags["test"] = "updated"
+			delete(expectedTags, "another")
+			expectedTags["new"] = "value"
+			Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(ammp), ammp)).To(Succeed())
+			ammp.Spec.AdditionalTags = expectedTags
+			Expect(mgmtClient.Update(ctx, ammp)).To(Succeed())
+			Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+
+			Byf("Restoring initial tags for machine pool %s", mp.Name)
+			expectedTags = initialTags
+			Expect(mgmtClient.Get(ctx, client.ObjectKeyFromObject(ammp), ammp)).To(Succeed())
+			ammp.Spec.AdditionalTags = expectedTags
+			Expect(mgmtClient.Update(ctx, ammp)).To(Succeed())
+			Eventually(checkTags, input.WaitForUpdate...).Should(Succeed())
+		}(mp)
+	}
+
+	wg.Wait()
+}

test/e2e/azure_test.go

@@ -632,6 +632,16 @@ var _ = Describe("Workload cluster creation", func() {
 					}
 				})
 			})
+
+			By("modifying additionalTags configuration", func() {
+				AKSAdditionalTagsSpec(ctx, func() AKSAdditionalTagsSpecInput {
+					return AKSAdditionalTagsSpecInput{
+						Cluster:       result.Cluster,
+						MachinePools:  result.MachinePools,
+						WaitForUpdate: e2eConfig.GetIntervals(specName, "wait-machine-pool-nodes"),
+					}
+				})
+			})
 		})
 	})