Merge pull request #3789 from mboersma/helm-are-you-even-retrying

Fix retrying in Helm e2e helper func

test/e2e/helm.go

@@ -68,11 +68,11 @@ func InstallHelmChart(ctx context.Context, clusterProxy framework.ClusterProxy,
 	}
 
 	// Install the chart and retry if needed
-	Eventually(func(g Gomega) {
+	Eventually(func() error {
 		cmd := exec.Command(helm, args...)
 		Logf("Helm command: %s", cmd.String())
 		output, err := cmd.CombinedOutput()
 		Logf("Helm install output: %s", string(output))
-		Expect(err).NotTo(HaveOccurred())
+		return err
 	}, helmInstallTimeout, retryableOperationSleepBetweenRetries).Should(Succeed())
 }