wip: add todo about zones

Signed-off-by: Karuppiah Natarajan <[email protected]>
kubernetes-sigs · Oct 2, 2021 · 0fdaabc · 0fdaabc
1 parent 5ce2b93
commit 0fdaabc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/azure/services/publicips/spec.go b/azure/services/publicips/spec.go
@@ -71,7 +71,7 @@ func (s PublicIPSpec) Parameters(existing interface{}) (interface{}, error) {
 	}
 
 	return network.PublicIPAddress{
-		// TODO(karuppiah7890): Add Tags with Cluster Name and other input
+		// TODO(karuppiah7890): Add Tags with Cluster Name and AdditionalTags and other input
 		// Tags: converters.TagsToMap(infrav1.Build(infrav1.BuildParams{
 		// 	ClusterName: s.Scope.ClusterName(),
 		// 	Lifecycle: infrav1.ResourceLifecycleOwned,
@@ -87,5 +87,6 @@ func (s PublicIPSpec) Parameters(existing interface{}) (interface{}, error) {
 			PublicIPAllocationMethod: network.IPAllocationMethodStatic,
 			DNSSettings:              dnsSettings,
 		},
+		// Zones: s.Zones()
 	}, nil
 }
diff --git a/azure/services/publicips/spec_test.go b/azure/services/publicips/spec_test.go
@@ -54,6 +54,7 @@ func TestParameters(t *testing.T) {
 						Fqdn:            to.StringPtr("fakedns.mydomain.io"),
 					},
 				},
+				// Zones: to.StringSlicePtr([]string{"1,2,3"}),
 			},
 		},
 		{
@@ -74,6 +75,7 @@ func TestParameters(t *testing.T) {
 					PublicIPAddressVersion:   network.IPVersionIPv4,
 					PublicIPAllocationMethod: network.IPAllocationMethodStatic,
 				},
+				// Zones: to.StringSlicePtr([]string{"1,2,3"}),
 			},
 		},
 		{
@@ -100,6 +102,7 @@ func TestParameters(t *testing.T) {
 						Fqdn:            to.StringPtr("fakename.mydomain.io"),
 					},
 				},
+				// Zones: to.StringSlicePtr([]string{"1,2,3"}),
 			},
 		},
 	}