update envtest k8s to 1.27

kubernetes-sigs · Sep 22, 2023 · 0903135 · 0903135
1 parent b195e9a
commit 0903135
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/Makefile b/Makefile
@@ -33,7 +33,7 @@ export GOPROXY
 export GO111MODULE=on
 
 # Kubebuilder.
-export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.20.2
+export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.27
 export KUBEBUILDER_CONTROLPLANE_START_TIMEOUT ?= 60s
 export KUBEBUILDER_CONTROLPLANE_STOP_TIMEOUT ?= 60s
 

diff --git a/controllers/suite_test.go b/controllers/suite_test.go
@@ -32,7 +32,8 @@ import (
 // http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
 
 var (
-	testEnv *env.TestEnvironment
+	testEnv       *env.TestEnvironment
+	testEnvCancel func()
 )
 
 func TestAPIs(t *testing.T) {
@@ -64,10 +65,13 @@ var _ = BeforeSuite(func() {
 
 	// +kubebuilder:scaffold:scheme
 
+	ctx, cancel := context.WithCancel(context.Background())
+	testEnvCancel = cancel
+
 	By("starting the manager")
 	go func() {
 		defer GinkgoRecover()
-		Expect(testEnv.StartManager()).To(Succeed())
+		Expect(testEnv.StartManager(ctx)).To(Succeed())
 	}()
 
 	Eventually(func() bool {
@@ -80,6 +84,7 @@ var _ = BeforeSuite(func() {
 })
 
 var _ = AfterSuite(func() {
+	testEnvCancel()
 	if testEnv != nil {
 		By("tearing down the test environment")
 		Expect(testEnv.Stop()).To(Succeed())

diff --git a/exp/controllers/suite_test.go b/exp/controllers/suite_test.go
@@ -35,7 +35,8 @@ import (
 // http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
 
 var (
-	testEnv *env.TestEnvironment
+	testEnv       *env.TestEnvironment
+	testEnvCancel func()
 )
 
 func TestAPIs(t *testing.T) {
@@ -60,10 +61,13 @@ var _ = BeforeSuite(func() {
 
 	// +kubebuilder:scaffold:scheme
 
+	mgrCtx, mgrCancel := context.WithCancel(context.Background())
+	testEnvCancel = mgrCancel
+
 	By("starting the manager")
 	go func() {
 		defer GinkgoRecover()
-		Expect(testEnv.StartManager()).To(Succeed())
+		Expect(testEnv.StartManager(mgrCtx)).To(Succeed())
 	}()
 
 	Eventually(func() bool {
@@ -76,6 +80,7 @@ var _ = BeforeSuite(func() {
 })
 
 var _ = AfterSuite(func() {
+	testEnvCancel()
 	if testEnv != nil {
 		By("tearing down the test environment")
 		Expect(testEnv.Stop()).To(Succeed())

diff --git a/internal/test/env/env.go b/internal/test/env/env.go
@@ -119,8 +119,8 @@ func NewTestEnvironment() *TestEnvironment {
 }
 
 // StartManager starts the test environment manager and blocks until the context is canceled.
-func (t *TestEnvironment) StartManager() error {
-	return t.Manager.Start(context.Background())
+func (t *TestEnvironment) StartManager(ctx context.Context) error {
+	return t.Manager.Start(ctx)
 }
 
 // Stop stops the test environment.