Convert project to kubebuilder version 2 #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
vincepri
reviewed
Aug 10, 2019
| @@ -42,77 +38,6 @@ type AWSClusterSpec struct { | |||
| SSHKeyName string `json:"sshKeyName,omitempty"` | |||
| } | |||
|
|
|||
| // NetworkSpec encapsulates all things related to AWS network. | |||
There was a problem hiding this comment.
Why move these? Seems they are only used within this file
There was a problem hiding this comment.
these got moved to keep the awscluster_types.go and awsmachine_types.go files to contain only the kubebuilder generated types. The supporting types live in types.go
k8s-ci-robot
added
the
needs-rebase
detiber
reviewed
Aug 12, 2019
k8s-ci-robot
removed
the
needs-rebase
chuckha
commented
Aug 12, 2019
chuckha
commented
Aug 12, 2019
chuckha
commented
Aug 12, 2019
detiber
reviewed
Aug 12, 2019
chuckha
changed the title
vincepri
reviewed
Aug 12, 2019
chuckha
force-pushed
the
kubebuilderv2
branch
6 times, most recently
from
33ead4f to
318470c
Compare
detiber
reviewed
Aug 13, 2019
config/crd/bases/infrastructure.cluster.x-k8s.io_awsclusters.yaml
Outdated
Show resolved
Hide resolved
chuckha
force-pushed
the
kubebuilderv2
branch
2 times, most recently
from
247972a to
393d2f8
Compare
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
detiber
reviewed
Aug 14, 2019
|
lgtm, but would like @vincepri to take a look since he's doing similar work in cluster-api |
Signed-off-by: Chuck Ha <[email protected]>
|
Taking a look now |
k8s-ci-robot
added
the
lgtm
This was referenced Aug 14, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
This PR converts capa to a kubebuilder v2 project.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #989
Special notes for your reviewer:
Release note: