Update CAPI dependency, remove clusterctl and make examples top level #923
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| @@ -1,21 +1,21 @@ | |||
| # Creating clusters using cross account role assumption using KIAM | |||
There was a problem hiding this comment.
Should we add a link at the top of this file to the same doc in the release-0.3 branch?
There was a problem hiding this comment.
That wouldn't hurt, are we serving docs from release-0.3 branch in this repo?
There was a problem hiding this comment.
We don't publish the docs anywhere other than from the git repo itself. Until we do, we should likely ensure that we add links to the release-0.3 doc to avoid user confusion when trying to consume releases.
There was a problem hiding this comment.
How would the link look like? Is that preferred to just revert the files to what they were before?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd like to avoid deferring docs changes, otherwise we risk missing more things than if we update in sync with the changes.
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
|
LGTM. @detiber? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR updates to the latest master version of Cluster API and removes the custom
clusterctlbinary. It also refactors the repository so the generated examples directory is top level.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: