A little make & bazel cleaning #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benefits include * Removes Make's direct dependency on `gcloud` for production builds * Reduce the number of unique variables (e.g. REGISTRY_STABLE vs REGISTRY_DEV) * Reduce the number of bazel targets to be more reusable Signed-off-by: Chuck Ha <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
detiber
reviewed
Mar 14, 2019
vincepri
reviewed
Mar 14, 2019
| @@ -1,6 +1,8 @@ | |||
| build --define=MANAGER_IMAGE_NAME=cluster-api-aws-controller | |||
| build --define=MANAGER_IMAGE_TAG=0.0.4 | |||
| build --define=REGISTRY_STABLE=gcr.io/cluster-api-provider-aws | |||
* Removes generated provider-components file from repo * Removes extra bazel and make targets Signed-off-by: Chuck Ha <[email protected]>
k8s-ci-robot
added
size/XXL
chuckha
commented
Mar 14, 2019
| @@ -47,4 +47,4 @@ kubeconfig | |||
|
|
|||
| # Ignore output manifests | |||
| cmd/clusterctl/examples/aws/out | |||
| cmd/clusterctl/examples/aws/provider-components-base-dev.yaml | |||
| cmd/clusterctl/examples/aws/provider-components-base.yaml | |||
There was a problem hiding this comment.
both -dev and this one are generated files. Neither of which should have been checked in
|
lgtm, leaving final lgtm to @vincepri |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-aws-bazel-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits include
gcloudfor production buildsWhat this PR does / why we need it:
These are some small clean ups that will make fixing #661 easier.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: