Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ashish-amarnath as a reviewer #616

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Adds ashish-amarnath as a reviewer #616

merged 1 commit into from
Mar 4, 2019

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Feb 27, 2019

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:

This PR adds @ashish-amarnath as a reviewer to the project. He's been a huge contributor to the project and regularly reviews code and provides feedback, features, tests and documentation. Really great to have you as an official reviewer!

NONE

/assign @detiber @vincepri @randomvariable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2019
@randomvariable
Copy link
Member

randomvariable commented Feb 27, 2019 •
edited
Loading

You need to add ashish OWNERS_ALIASES, not this file

detiber
detiber reviewed Feb 27, 2019
View reviewed changes
OWNERS Outdated
@@ -10,3 +10,4 @@ approvers:
reviewers:
- cluster-api-maintainers
- cluster-api-aws-maintainers
- ashish-amarnath
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a new alias for reviewers

@chuckha
Copy link
Contributor Author

chuckha commented Feb 27, 2019

ah ok, yeah I'll add a new reviewers group and add that to the owners file

@chuckha
Copy link
Contributor Author

chuckha commented Feb 27, 2019

/cc @ashish-amarnath

oops lol

@randomvariable
Copy link
Member

+1

@detiber
Copy link
Member

detiber commented Feb 27, 2019

Adding hold for lazy consensus

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2019
@detiber
Copy link
Member

detiber commented Feb 27, 2019

+1 from me

/assign davidewatson
/assign d-nishi
/assign enxebre
/assign ingvagabund
/assign vincepri

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to assign the following users: enxebre.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

+1 from me

/assign davidewatson
/assign d-nishi
/assign enxebre
/assign ingvagabund
/assign vincepri

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

vincepri commented Feb 27, 2019 •
edited
Loading

+1 from me as well :)

@davidewatson
Copy link
Contributor

👍

vincepri
vincepri approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2019
@detiber
Copy link
Member

detiber commented Mar 4, 2019

Removing hold, since there have been no objections to this PR
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5bf5275 into kubernetes-sigs:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@ashish-amarnath ashish-amarnath ashish-amarnath approved these changes

@vincepri vincepri vincepri approved these changes

@krousey krousey Awaiting requested review from krousey

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@detiber detiber

@randomvariable randomvariable

@vincepri vincepri

@ingvagabund ingvagabund

@davidewatson davidewatson

@d-nishi d-nishi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@chuckha @k8s-ci-robot @randomvariable @detiber @vincepri @davidewatson @ashish-amarnath @ingvagabund @d-nishi