Rev versions of containerd and Kubernetes #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
detiber
force-pushed
the
revContainerd
branch
from
5ca36f2 to
c0678c8
Compare
sfzylad
reviewed
Feb 14, 2019
sfzylad
reviewed
Feb 14, 2019
| @@ -3,7 +3,7 @@ | |||
| "aws_access_key": "", | |||
| "aws_secret_key": "", | |||
| "build_timestamp": "{{timestamp}}", | |||
| "kubernetes_version": "1.13.2-00", | |||
| "kubernetes_version": "1.13.3-00", | |||
There was a problem hiding this comment.
Same here. It may be worth testing if the packages we want to install are there.
There was a problem hiding this comment.
I don't think a Goss test is needed here because the Ansible playbook will fail if the specified version of the package is not installed.
k8s-ci-robot
added
size/L
chuckha
reviewed
Feb 14, 2019
Signed-off-by: Naadir Jeewa <[email protected]> Signed-off-by: Naadir Jeewa <[email protected]>
Signed-off-by: Naadir Jeewa <[email protected]> Signed-off-by: Naadir Jeewa <[email protected]>
Signed-off-by: Naadir Jeewa <[email protected]> Signed-off-by: Naadir Jeewa <[email protected]>
Signed-off-by: Naadir Jeewa <[email protected]> Signed-off-by: Naadir Jeewa <[email protected]>
Signed-off-by: Naadir Jeewa <[email protected]> Signed-off-by: Naadir Jeewa <[email protected]>
detiber
force-pushed
the
revContainerd
branch
from
ca4fbaf to
6e9348d
Compare
detiber
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@chuckha this should be good to go now. |
Merged
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #570
Release note:
Outstanding TODOs for this PR: