Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add create-ha-cluster clusterawsadm subcommand #528

Closed
wants to merge 16 commits into from

Conversation

sfzylad
Copy link
Contributor

@sfzylad sfzylad commented Jan 29, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #415

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sfzylad
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: d-nishi

If they are not already assigned, you can assign the PR to them by writing /assign @d-nishi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sfzylad sfzylad changed the title Add create-ha-control-plane clusterawsadm subcommand [WIP] Add create-ha-control-plane clusterawsadm subcommand Jan 29, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sfzylad. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2019
@sfzylad sfzylad changed the title [WIP] Add create-ha-control-plane clusterawsadm subcommand [WIP] Add create-ha-cluster clusterawsadm subcommand Jan 29, 2019
@detiber
Copy link
Member

detiber commented Jan 29, 2019

@sfzylad this PR will likely be blocked until the pivot phase exists in clusterctl (kubernetes-sigs/cluster-api#554).

@vincepri
Copy link
Member

vincepri commented Mar 7, 2019

/milestone v1alpha1

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2019
@sfzylad sfzylad force-pushed the ha-cluster-bin branch 2 times, most recently from a4c45ea to 18d6745 Compare March 19, 2019 09:55
@ncdc
Copy link
Contributor

ncdc commented Mar 25, 2019

We'll want adequate time to test this and the v1alpha1 release is at the end of this week. Given that we have documentation on how to create a multi-node control plane, I'm comfortable deferring this until after the release.

/milestone Next

@k8s-ci-robot k8s-ci-robot modified the milestones: v1alpha1, Next Mar 25, 2019
@sfzylad sfzylad force-pushed the ha-cluster-bin branch 2 times, most recently from eb8bdf9 to a28933e Compare April 2, 2019 16:51
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

@sfzylad: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-aws-bazel-build d765c63 link /test pull-cluster-api-provider-aws-bazel-build
pull-cluster-api-provider-aws-bazel-verify d765c63 link /test pull-cluster-api-provider-aws-bazel-verify
pull-cluster-api-provider-aws-bazel-test d765c63 link /test pull-cluster-api-provider-aws-bazel-test
pull-cluster-api-provider-aws-bazel-integration d765c63 link /test pull-cluster-api-provider-aws-bazel-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sfzylad
Copy link
Contributor Author

sfzylad commented Apr 16, 2019

This PR is no longer valid. Because this has been implemented in CAPI, #720 has been created instead to solve this problem.

@sfzylad
Copy link
Contributor Author

sfzylad commented Apr 16, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@sfzylad: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary for automating HA cluster creation
5 participants