-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add create-ha-cluster
clusterawsadm subcommand
#528
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sfzylad If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
create-ha-control-plane
clusterawsadm subcommandcreate-ha-control-plane
clusterawsadm subcommand
Hi @sfzylad. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
create-ha-control-plane
clusterawsadm subcommandcreate-ha-cluster
clusterawsadm subcommand
@sfzylad this PR will likely be blocked until the pivot phase exists in |
/milestone v1alpha1 |
a4c45ea
to
18d6745
Compare
We'll want adequate time to test this and the v1alpha1 release is at the end of this week. Given that we have documentation on how to create a multi-node control plane, I'm comfortable deferring this until after the release. /milestone Next |
eb8bdf9
to
a28933e
Compare
@sfzylad: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is no longer valid. Because this has been implemented in CAPI, #720 has been created instead to solve this problem. |
/close |
@sfzylad: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #415
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: