-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix(addons): add configuration to IsEqual cmp #5199
🐛 fix(addons): add configuration to IsEqual cmp #5199
Conversation
|
Welcome @gutmensch! |
Hi @gutmensch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5a593ae
to
68098d9
Compare
* add ResolveConflicts to cmp too * add tests
68098d9
to
30e364c
Compare
/ok-to-test |
/lgtm |
Thanks @gutmensch /cherrypick release-2.7 |
@richardcase: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@richardcase: new pull request created: #5202 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently a configuration change of an AddOn is not reconciled by capa and needs manual fixing (e.g. in the AWS console), this PR fixes the behaviour. The PR also adds basic tests for the IsEqual function and its expected results.
Which issue(s) this PR fixes
Fixes #5086
Special notes for your reviewer:
Checklist:
Release note: