Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Align cluster-template.yaml and cluster-template-machinepool.yaml, use external cloud controller and CSI #5136

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 7, 2024

What type of PR is this?

/kind support

What this PR does / why we need it:

Ensure the two templates mostly only differ in AWSMachineDeployment vs. AWSMachinePool (easier to review via diff -U0 templates/{cluster-template.yaml,cluster-template-machinepool.yaml}).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

n/a

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Templates: align `cluster-template.yaml` and `cluster-template-machinepool.yaml`, use external cloud controller and CSI

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2024
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@richardcase
Copy link
Member

/cherrypick release-2.6

@k8s-infra-cherrypick-robot

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1245ff7 into kubernetes-sigs:main Oct 7, 2024
22 of 23 checks passed
@k8s-infra-cherrypick-robot

@richardcase: #5136 failed to apply on top of branch "release-2.6":

Applying: Align `cluster-template.yaml` and `cluster-template-machinepool.yaml`, use external cloud controller and CSI
Using index info to reconstruct a base tree...
M	templates/cluster-template-external-cloud-provider.yaml
M	templates/cluster-template-flatcar.yaml
M	templates/cluster-template.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/cluster-template.yaml
Auto-merging templates/cluster-template-flatcar.yaml
CONFLICT (content): Merge conflict in templates/cluster-template-flatcar.yaml
CONFLICT (modify/delete): templates/cluster-template-external-cloud-provider.yaml deleted in Align `cluster-template.yaml` and `cluster-template-machinepool.yaml`, use external cloud controller and CSI and modified in HEAD. Version HEAD of templates/cluster-template-external-cloud-provider.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Align `cluster-template.yaml` and `cluster-template-machinepool.yaml`, use external cloud controller and CSI
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants