Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Don't reconcile security groups on NLBs from older versions of CAPA #4794

Merged
merged 1 commit into from
Feb 21, 2024
Merged

🐛 Don't reconcile security groups on NLBs from older versions of CAPA #4794

merged 1 commit into from
Feb 21, 2024

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Feb 15, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

The logic introduced in #4733 removed the checks on attaching security groups to network load balancers. This is fine for newly created NLBs, but for ones created in older versions of CAPI, security groups cannot be attached, and we should respect those settings still.

Which issue(s) this PR fixes
Fixes #4790

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emojis
  • adds unit tests

Release note:

NONE

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2024
@nrb
Copy link
Contributor Author

nrb commented Feb 15, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@nrb: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nrb
Copy link
Contributor Author

nrb commented Feb 15, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 16, 2024
@nrb
Copy link
Contributor Author

nrb commented Feb 19, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking

@AndiDog
Copy link
Contributor

AndiDog commented Feb 19, 2024

/assign

@nrb
Don't reconcile security groups on older NLBs
23828d5 
Network load balancers created under older versions of CAPI did not have
security groups added at creation, and therefore could not have any
security groups set at all.

Allow NLBs created in this configuration to continue reconciling.

Signed-off-by: Nolan Brubaker <[email protected]>
@richardcase
Copy link
Member

/milestone v2.4.0

@k8s-ci-robot k8s-ci-robot added this to the v2.4.0 milestone Feb 20, 2024
damdo
damdo reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for the fix.

/assign @richardcase
For final approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2024
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member

damdo commented Feb 21, 2024

Pod got killed, retrying:

/test pull-cluster-api-provider-aws-e2e

vincepri
vincepri approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@vincepri
Copy link
Member

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented Feb 21, 2024

/retest

@nrb
Copy link
Contributor Author

nrb commented Feb 21, 2024

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@nrb
Copy link
Contributor Author

nrb commented Feb 21, 2024

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot k8s-ci-robot merged commit 8b4231d into kubernetes-sigs:main Feb 21, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@AndiDog AndiDog AndiDog left review comments

@vincepri vincepri vincepri approved these changes

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

Assignees

@richardcase richardcase

@AndiDog AndiDog

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Network Load Balancers won't reconcile in main
6 participants
@nrb @k8s-ci-robot @AndiDog @richardcase @damdo @vincepri