Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.0] Reconcile EKSConfig correctly for MachinePool and other Owner kinds #4353

Merged
merged 1 commit into from
Jun 20, 2023
Merged

[release-2.0] Reconcile EKSConfig correctly for MachinePool and other Owner kinds #4353

merged 1 commit into from
Jun 20, 2023

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Jun 20, 2023 •
edited
Loading

What type of PR is this?
/kind backport

What this PR does / why we need it:
Backport of #4195

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Reconcile EKSConfig correctly for MachinePool and other Owner kinds

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 20, 2023
@Ankitasw Ankitasw changed the title Backport eksconfig [release-2.0] Reconcile EKSConfig correctly for MachinePool and other Owner kinds Jun 20, 2023
@Ankitasw Ankitasw force-pushed the backport-eksconfig branch from 4bbae3b to 18275b5 Compare June 20, 2023 08:26
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 20, 2023
@Ankitasw Ankitasw force-pushed the backport-eksconfig branch 2 times, most recently from c00f932 to 01b6b36 Compare June 20, 2023 08:39
@Ankitasw Ankitasw requested a review from dlipovetsky June 20, 2023 09:46
@Skarlso
Copy link
Contributor

Skarlso commented Jun 20, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@Ankitasw Ankitasw force-pushed the backport-eksconfig branch from 01b6b36 to a3331a5 Compare June 20, 2023 11:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@Skarlso
Copy link
Contributor

Skarlso commented Jun 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@Ankitasw Ankitasw added the kind/backport Issues or PRs requiring backports label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0d70250 into kubernetes-sigs:release-2.0 Jun 20, 2023
@Ankitasw Ankitasw deleted the backport-eksconfig branch June 20, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@Skarlso Skarlso Awaiting requested review from Skarlso

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@Skarlso Skarlso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/backport Issues or PRs requiring backports lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ankitasw @Skarlso @k8s-ci-robot @cnmcavoy