fix: Replace misleading wording used for security group overrides #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wording "overridden" is misleading. In every case where the wording is used to reference a security group, the security group is being overridden. Instead, it is the security group provided as an override.
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-priority
size/S
Ankitasw
reviewed
Nov 11, 2022
| @@ -193,7 +193,7 @@ func (s *ManagedControlPlaneScope) SecondaryCidrBlock() *string { | |||
| return s.ControlPlane.Spec.SecondaryCidrBlock | |||
| } | |||
|
|
|||
| // SecurityGroupOverrides returns the security groups that are overridden in the ControlPlane spec. | |||
| // SecurityGroupOverrides returns the security groups that are overrides in the ControlPlane spec. | |||
There was a problem hiding this comment.
Suggested change
| // SecurityGroupOverrides returns the security groups that are overrides in the ControlPlane spec. | |
| // SecurityGroupOverrides returns the security groups that are used as overrides in the ControlPlane spec. |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording "overridden" is misleading. In every case where the wording is used to reference a security group, the security group is being overridden. Instead, it is the security group provided as an override.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The wording "overridden" is misleading. In every case where the wording is used to reference a security group, the security group is being overridden. Instead, it is the security group provided as an override.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: