Clean up internet-facing loadbalancer scheme logic #3832
Conversation
k8s-ci-robot
added
kind/cleanup
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-aws-e2e-blocking |
|
/retest |
|
Need to look at the test failure locally |
Ankitasw
force-pushed
the
cleanup-internet-facing-logic
branch
from
c536d1c
to
ddca02f
Compare
k8s-ci-robot
removed
the
lgtm
Ankitasw
force-pushed
the
cleanup-internet-facing-logic
branch
2 times, most recently
from
0338657
to
42a970a
Compare
|
/test pull-cluster-api-provider-aws-e2e-blocking |
Ankitasw
force-pushed
the
cleanup-internet-facing-logic
branch
from
42a970a
to
5ed74b2
Compare
Ankitasw
force-pushed
the
cleanup-internet-facing-logic
branch
from
5ed74b2
to
ce55e2f
Compare
|
/test pull-cluster-api-provider-aws-e2e |
|
/milestone v2.0.0 |
|
@Ankitasw: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks! The apidiff failure is expected. /lgtm |
k8s-ci-robot
added
the
lgtm
|
Test passing locally so |
|
@Ankitasw: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-cluster-api-provider-aws-e2e-blocking |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
To fix a casing issue (#2768), we had some custom logic implemented #2801.
With v1beta2 API version, we no longer need this custom logic as users were not allowed to use the incorrect LB scheme (Internet-facing) in v1beta1.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3673
Special notes for your reviewer:
Checklist: