Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] Fix ProviderIDList in managed machinepool #3818

Merged

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Nov 4, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
Due to provider ID matching logic changes in core CAPI, ProviderIdList need to be populated correctly.
Fix for unmanaged machine pools is #3743 and this PR does the same for managed machine pools.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2022
@richardcase
Copy link
Member

/retest

@Ankitasw Ankitasw changed the title Fix Provider id list in managed machinepool [release-1.5] Fix Provider id list in managed machinepool Nov 4, 2022
@Ankitasw Ankitasw changed the title [release-1.5] Fix Provider id list in managed machinepool [release-1.5] Fix ProvideIDList in managed machinepool Nov 4, 2022
@Ankitasw Ankitasw changed the title [release-1.5] Fix ProvideIDList in managed machinepool [release-1.5] Fix ProviderIDList in managed machinepool Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
@AverageMarcus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Nov 5, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4d83291 into kubernetes-sigs:release-1.5 Nov 5, 2022
@Ankitasw Ankitasw deleted the providerIdList-fix branch November 5, 2022 08:21
@richardcase
Copy link
Member

/milestone v1.5.2

@k8s-ci-robot k8s-ci-robot added this to the v1.5.2 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants