Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Bump NVIDIA GPU operator version in GPU tests #3661

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Aug 10, 2022

What type of PR is this?
Add one of the following kinds:
/kind failing-test

What this PR does / why we need it:
This PR updates the GPU operator version to v1.11.1 so as to fix the failing GPU tests. Operator deprecated use of some of cuda base images in the init containers because of which the tests were failing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3660
Original issue NVIDIA/gpu-operator#388

Special notes for your reviewer:
Since we are maintaining manifests, we need to port the cluster policy CRD and gpu operator resources from NVIDIA gpu-operator repo with every version bump.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2022
@Ankitasw Ankitasw changed the title [E2E] Bump nvidia GPU operator version in GPU tests [wip] [E2E] Bump nvidia GPU operator version in GPU tests Aug 10, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022
@Ankitasw Ankitasw changed the title [wip] [E2E] Bump nvidia GPU operator version in GPU tests [wip] [E2E] Bump NVIDIA GPU operator version in GPU tests Aug 10, 2022
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw Ankitasw changed the title [wip] [E2E] Bump NVIDIA GPU operator version in GPU tests [E2E] Bump NVIDIA GPU operator version in GPU tests Aug 11, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Aug 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@richardcase
Copy link
Member

Until the remaining test passes:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@Ankitasw
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 34944d6 into kubernetes-sigs:main Aug 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Aug 11, 2022
@Ankitasw Ankitasw deleted the gpu-test-fix branch August 11, 2022 07:27
@sedefsavas
Copy link
Contributor

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@sedefsavas: new pull request created: #3676

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU e2e test fails
6 participants