-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssm test based on ClusterClass #3448
Add ssm test based on ClusterClass #3448
Conversation
@pydctw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e |
e2e tests for newly added tests passed [2] • [SLOW TEST:846.463 seconds]
[2] [unmanaged] [functional] [ClusterClass]
[2] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:41
[2] Workload cluster with AWS SSM Parameter as the Secret Backend [ClusterClass]
[2] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:95
[2] should be creatable and deletable
[2] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:96 verify failure is not related to this PR. |
test/e2e/data/infrastructure-aws/kustomize_sources/topology/cluster-template.yaml
Show resolved
Hide resolved
test/e2e/data/infrastructure-aws/kustomize_sources/topology/clusterclass-quick-start.yaml
Outdated
Show resolved
Hide resolved
test/e2e/data/infrastructure-aws/kustomize_sources/topology/clusterclass-quick-start.yaml
Show resolved
Hide resolved
test/e2e/data/infrastructure-aws/kustomize_sources/topology/clusterclass-quick-start.yaml
Outdated
Show resolved
Hide resolved
6542c87
to
46065eb
Compare
Thanks @shivi28. Addressed the review comments. Take another look. |
/test pull-cluster-api-provider-aws-e2e |
@pydctw: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
GPU test failure is a flake, not related to this PR. [1] • Failure [983.862 seconds]
[1] [unmanaged] [functional]
[1] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:50
[1] GPU-enabled cluster test
[1] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:62
[1] should create cluster with single worker [It]
[1] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:63
[1]
[1] Timed out after 600.074s. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add ssm test based on ClusterClass
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #3346
Special notes for your reviewer:
Started the effort to combine ClusterClasses. This test refactored and added more capabilities to the existing ClusterClass.
Checklist: