Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssm test based on ClusterClass #3448

Merged
merged 1 commit into from
May 5, 2022

Conversation

pydctw
Copy link
Contributor

@pydctw pydctw commented Apr 26, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add ssm test based on ClusterClass

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #3346

Special notes for your reviewer:
Started the effort to combine ClusterClasses. This test refactored and added more capabilities to the existing ClusterClass.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2022
@k8s-ci-robot
Copy link
Contributor

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Apr 26, 2022

/test pull-cluster-api-provider-aws-e2e

@pydctw
Copy link
Contributor Author

pydctw commented Apr 26, 2022

e2e tests for newly added tests passed

[2] • [SLOW TEST:846.463 seconds]
[2] [unmanaged] [functional] [ClusterClass]
[2] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:41
[2]   Workload cluster with AWS SSM Parameter as the Secret Backend [ClusterClass]
[2]   /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:95
[2]     should be creatable and deletable
[2]     /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:96

verify failure is not related to this PR.

@pydctw pydctw force-pushed the cc-e2e-secret-backend branch from 6542c87 to 46065eb Compare April 29, 2022 18:03
@pydctw
Copy link
Contributor Author

pydctw commented Apr 29, 2022

Thanks @shivi28. Addressed the review comments. Take another look.

@pydctw
Copy link
Contributor Author

pydctw commented Apr 29, 2022

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot
Copy link
Contributor

@pydctw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e 46065eb link false /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pydctw
Copy link
Contributor Author

pydctw commented Apr 29, 2022

GPU test failure is a flake, not related to this PR.

[1] • Failure [983.862 seconds]
[1] [unmanaged] [functional]
[1] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:50
[1]   GPU-enabled cluster test
[1]   /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:62
[1]     should create cluster with single worker [It]
[1]     /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:63
[1] 
[1]     Timed out after 600.074s.

@shivi28
Copy link
Contributor

shivi28 commented Apr 30, 2022

Thanks @shivi28. Addressed the review comments. Take another look.

Thanks @pydctw, I have addressed the comments. PTAL at once, else /lgtm

@sedefsavas
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 913ee94 into kubernetes-sigs:main May 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants