Add multi-tenancy test based on ClusterClass #3389

pydctw · 2022-04-05T17:08:58Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add a multi-tenancy test based on ClusterClass to verify CAPA is supporting CAPI's newly added ClusterClass feature.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #3346

Special notes for your reviewer:
Note that unmanaged_CAPI_quick_test_cluster_class.go was renamed to
unmanaged_CAPI_quick_clusterclass_test.go as there are linter rules that
applies to test files and the assumption is that test files end with _test.go.

Checklist:

squashed commits
includes documentation
adds unit tests
adds or updates e2e tests

k8s-ci-robot · 2022-04-05T17:09:06Z

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pydctw · 2022-04-05T17:09:17Z

/test ?

k8s-ci-robot · 2022-04-05T17:09:18Z

@pydctw: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pydctw · 2022-04-05T17:09:28Z

/test pull-cluster-api-provider-aws-e2e

pydctw · 2022-04-05T17:14:34Z

Submitted a PR for test-infra: kubernetes/test-infra#25874

The proposal is to create a new prow job that runs ClusterClass-based tests separately but feedback will be appreciated.

pydctw · 2022-04-05T17:50:12Z

/hold

pydctw · 2022-04-05T17:58:28Z

/test pull-cluster-api-provider-aws-e2e

pydctw · 2022-04-05T18:05:50Z

@sbueringer @fabriziopandini, it will be great to get your reviews esp. for the ClusterClass as I will be building more ClusterClasses based on this one.

pydctw · 2022-04-05T19:03:32Z

The new ClusterClass test passed: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3389/pull-cluster-api-provider-aws-e2e/1511402911341481984

[1] • [SLOW TEST:1507.556 seconds]
[1] [unmanaged] [functional] [ClusterClass]
[1] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:38
[1]   Multitenancy test [ClusterClass]
[1]   /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:50
[1]     should create cluster with nested assumed role
[1]     /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go:51

pydctw · 2022-04-05T19:05:49Z

Some unrelated tests (Self Hosted Spec and Machine Pool Spec) are failing with timeout, which could be an infra issue. Will rerun the test and see what happens.
-> Updates: ok, it was a flak. Now these random failures are gone.

pydctw · 2022-04-05T23:15:55Z

/retest

sbueringer

Looks good from my side. Just a few comments/ideas.

Thx for cc, it's really nice to see how ClusterClass is used in practices / works (or not :)).

Feel free to mention me on similar PRs as well, if you want to.

test/e2e/suites/unmanaged/unmanaged_functional_clusterclass_test.go

...cture-aws/kustomize_sources/nested-multitenancy-clusterclass/clusterclass-multi-tenancy.yaml

pydctw · 2022-04-07T19:27:11Z

/test pull-cluster-api-provider-aws-e2e

pydctw · 2022-04-07T19:52:17Z

/hold cancel

pydctw · 2022-04-07T22:05:54Z

Another flake - ignition test is failing which is not related with the code changes.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3389/pull-cluster-api-provider-aws-e2e/1512164109666226176

capa-e2e: [unmanaged] [functional] Workload cluster with AWS S3 and Ignition parameter It should be creatable and deletable expand_less | 29m1s
-- | --
{ Failure /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_functional_test.go:1049 Timed out after 1500.000s. Expected     <bool>: false to be true /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/controlplane_helpers.go:147}

pydctw · 2022-04-07T22:06:01Z

/retest

pydctw · 2022-04-11T15:23:09Z

@sedefsavas, could you review the PR? As I plan to follow a similar pattern for following ClusterClass e2e PRs, hope to get it merged it soon.

test-infra PR also needs a review but that is not blocking this PR.

sedefsavas · 2022-04-11T16:37:16Z

@shivi28 volunteered to review.

shivi28

Thanks Winnie
There is one small suggestion, else
/lgtm

...cture-aws/kustomize_sources/nested-multitenancy-clusterclass/clusterclass-multi-tenancy.yaml

Also, renamed unmanaged_CAPI_quick_test_cluster_class.go to unmanaged_CAPI_quick_clusterclass_test.go as there are linter rules that applies to test files and the assumption is that test files end with `_test.go`.

pydctw · 2022-04-13T15:25:48Z

/test pull-cluster-api-provider-aws-e2e

pydctw · 2022-04-13T17:28:40Z

Ready for the final review, @sedefsavas

test/e2e/data/e2e_conf.yaml

.../infrastructure-aws/kustomize_sources/nested-multitenancy-clusterclass/cluster-template.yaml

sedefsavas · 2022-04-14T23:44:46Z

/approve

k8s-ci-robot · 2022-04-14T23:45:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shivi28 · 2022-04-18T15:41:47Z

/lgtm

shivi28 · 2022-04-18T15:46:48Z

/hold

shivi28 · 2022-04-18T15:49:33Z

/unhold

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 5, 2022

k8s-ci-robot requested review from Ankitasw and sedefsavas April 5, 2022 17:09

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2022

pydctw force-pushed the cc-e2e-multi-tenancy branch from 3fb3957 to ff8fbe5 Compare April 5, 2022 17:57

sbueringer reviewed Apr 6, 2022

View reviewed changes

pydctw force-pushed the cc-e2e-multi-tenancy branch from ff8fbe5 to d266752 Compare April 7, 2022 19:25

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022

shivi28 reviewed Apr 13, 2022

View reviewed changes

k8s-ci-robot assigned shivi28 Apr 13, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022

Add multi-tenancy test based on ClusterClass

ccb2cca

Also, renamed unmanaged_CAPI_quick_test_cluster_class.go to unmanaged_CAPI_quick_clusterclass_test.go as there are linter rules that applies to test files and the assumption is that test files end with `_test.go`.

pydctw force-pushed the cc-e2e-multi-tenancy branch from d266752 to ccb2cca Compare April 13, 2022 15:23

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022

sedefsavas reviewed Apr 14, 2022

View reviewed changes

test/e2e/data/e2e_conf.yaml Show resolved Hide resolved

.../infrastructure-aws/kustomize_sources/nested-multitenancy-clusterclass/cluster-template.yaml Show resolved Hide resolved

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2022

k8s-ci-robot merged commit 2c454a0 into kubernetes-sigs:main Apr 18, 2022

k8s-ci-robot added this to the v1.x milestone Apr 18, 2022

pydctw deleted the cc-e2e-multi-tenancy branch November 9, 2022 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add multi-tenancy test based on ClusterClass #3389

Add multi-tenancy test based on ClusterClass #3389

pydctw commented Apr 5, 2022

k8s-ci-robot commented Apr 5, 2022

pydctw commented Apr 5, 2022

k8s-ci-robot commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022 •

edited

Loading

pydctw commented Apr 5, 2022 •

edited

Loading

pydctw commented Apr 5, 2022 •

edited

Loading

pydctw commented Apr 5, 2022

sbueringer left a comment •

edited

Loading

pydctw commented Apr 7, 2022

pydctw commented Apr 7, 2022

pydctw commented Apr 7, 2022

pydctw commented Apr 7, 2022

pydctw commented Apr 11, 2022 •

edited

Loading

sedefsavas commented Apr 11, 2022

shivi28 left a comment

pydctw commented Apr 13, 2022

pydctw commented Apr 13, 2022

sedefsavas commented Apr 14, 2022

k8s-ci-robot commented Apr 14, 2022

shivi28 commented Apr 18, 2022

shivi28 commented Apr 18, 2022

shivi28 commented Apr 18, 2022

Add multi-tenancy test based on ClusterClass #3389

Add multi-tenancy test based on ClusterClass #3389

Conversation

pydctw commented Apr 5, 2022

k8s-ci-robot commented Apr 5, 2022

pydctw commented Apr 5, 2022

k8s-ci-robot commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022

pydctw commented Apr 5, 2022 • edited Loading

pydctw commented Apr 5, 2022 • edited Loading

pydctw commented Apr 5, 2022 • edited Loading

pydctw commented Apr 5, 2022

sbueringer left a comment • edited Loading

Choose a reason for hiding this comment

pydctw commented Apr 7, 2022

pydctw commented Apr 7, 2022

pydctw commented Apr 7, 2022

pydctw commented Apr 7, 2022

pydctw commented Apr 11, 2022 • edited Loading

sedefsavas commented Apr 11, 2022

shivi28 left a comment

Choose a reason for hiding this comment

pydctw commented Apr 13, 2022

pydctw commented Apr 13, 2022

sedefsavas commented Apr 14, 2022

k8s-ci-robot commented Apr 14, 2022

shivi28 commented Apr 18, 2022

shivi28 commented Apr 18, 2022

shivi28 commented Apr 18, 2022

pydctw commented Apr 5, 2022 •

edited

Loading

pydctw commented Apr 5, 2022 •

edited

Loading

pydctw commented Apr 5, 2022 •

edited

Loading

sbueringer left a comment •

edited

Loading

pydctw commented Apr 11, 2022 •

edited

Loading