Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using setup-envtest to install kubebuilder dependency #3362

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 29, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Changes to use setup-envtest tool to set up kubebuilder dependency for test environment instead of the script that we had previously.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3086

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Uses setup-envtest to install kubebuilder dependency for the unit tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

@Skarlso: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Skarlso. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/contains-merge-commits size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@Skarlso Skarlso force-pushed the use-setup-envtest branch from e1b975f to 13c4db4 Compare March 29, 2022 08:15
@Ankitasw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 29, 2022

Oh ops, seems like, there are some references I didn't remove....

@Skarlso Skarlso force-pushed the use-setup-envtest branch from 13c4db4 to c94895d Compare March 29, 2022 09:42
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 29, 2022

/retest

Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you will need to run go mod tidy as well from looking at the verification failure.

Makefile Outdated Show resolved Hide resolved
@Skarlso Skarlso force-pushed the use-setup-envtest branch from c94895d to 170f9fe Compare March 29, 2022 09:52
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 29, 2022

/retest

@Skarlso Skarlso force-pushed the use-setup-envtest branch from 170f9fe to 8e8f07a Compare March 29, 2022 10:14
@richardcase
Copy link
Member

Thanks @Skarlso

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2022
@richardcase
Copy link
Member

Thanks @Skarlso

/lgtm
/approve

1 similar comment
@richardcase
Copy link
Member

Thanks @Skarlso

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cacbdea into kubernetes-sigs:main Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Mar 29, 2022
@Skarlso Skarlso deleted the use-setup-envtest branch March 29, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use controller-runtime setup-envtest instead of fetch_ext_bins.sh
4 participants