-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport-v1alpha3] Correct the casing of internet-facing ELB scheme #2862
[Backport-v1alpha3] Correct the casing of internet-facing ELB scheme #2862
Conversation
/triage accepted |
ca90ae4
to
57ff8bf
Compare
57ff8bf
to
65f1525
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me. Wondering if we could have used the cherry-pick command? But:
/lgtm
Yeah, we could have. I forgot to tell @sedefsavas about it... |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The reason I didn't use cherry pick was there were some differences between backports regarding which versions need to have the change, also v1alpha3 webhook implementation was different. |
/kind bug
What this PR does / why we need it:
Backport of #2832
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: