Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1beta1 APIs support in CAPA #2803

Closed
wants to merge 11 commits into from
Closed

Add v1beta1 APIs support in CAPA #2803

wants to merge 11 commits into from

Conversation

shivi28
Copy link
Contributor

@shivi28 shivi28 commented Sep 26, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2792

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add v1beta1 APIs in core types

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cecilerobertmichon after the PR has been reviewed.
You can assign the PR to them by writing /assign @cecilerobertmichon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2021
@randomvariable
Copy link
Member

Shivani, this PR needs to be massively rebased, it has 34 commits including from other PRs?

@shivi28 shivi28 changed the title [WIP] Add v1beta1 APIs in core types Add v1beta1 APIs in core types Sep 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2021
@shivi28 shivi28 changed the title Add v1beta1 APIs in core types [WIP]Add v1beta1 APIs in core types Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2021
@shivi28 shivi28 changed the title [WIP]Add v1beta1 APIs in core types Add v1beta1 APIs in core types Sep 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2021
@shivi28 shivi28 changed the title Add v1beta1 APIs in core types Add v1beta1 APIs support in CAPA Sep 30, 2021
@shivi28
Copy link
Contributor Author

shivi28 commented Sep 30, 2021

/test ?

@k8s-ci-robot
Copy link
Contributor

@shivi28: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shivi28
Copy link
Contributor Author

shivi28 commented Sep 30, 2021

/test pull-cluster-api-provider-aws-e2e-eks

randomvariable
randomvariable reviewed Oct 1, 2021
View reviewed changes
test/e2e/data/e2e_conf.yaml
@@ -42,7 +42,7 @@ providers:
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.1/core-components.yaml"
type: "url"
files:
- sourcePath: "./shared/v1alpha4/metadata.yaml"
- sourcePath: "./shared/v1beta1/metadata.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist. Needs to be copied from https://github.com/kubernetes-sigs/cluster-api/blob/main/metadata.yaml

randomvariable
randomvariable reviewed Oct 1, 2021
View reviewed changes
test/e2e/data/e2e_conf.yaml
@@ -65,7 +65,7 @@ providers:
- name: kubeadm
type: BootstrapProvider
files:
- sourcePath: "./shared/v1alpha4/metadata.yaml"
- sourcePath: "./shared/v1beta1/metadata.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the CAPI components need updating to v1.0.0-rc.0 if we want e2e tests to work.

@randomvariable
Copy link
Member

Hold on this one @shivi28 . I'll get some other bits and pieces in and test them all together.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 4, 2021 •
edited
Loading

@shivi28: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-eks 20623aaaf28095706d4cae6fca616a4c11fb8c6f link false /test pull-cluster-api-provider-aws-e2e-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

@shivi28: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randomvariable
Copy link
Member

Closing this out in favour of #2820 that includes this PR.

/close

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closed this PR.

In response to this:

Closing this out in favour of #2820 that includes this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomvariable randomvariable randomvariable left review comments

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add v1beta1 types
3 participants
@shivi28 @k8s-ci-robot @randomvariable