Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the doc for using external CCM with CSI driver to summary_prefix.md #2724

Merged
merged 1 commit into from
Sep 2, 2021
Merged

fix: add the doc for using external CCM with CSI driver to summary_prefix.md #2724

merged 1 commit into from
Sep 2, 2021

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Sep 1, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:
The doc which was added for using external cloud provider with EBS CSI driver was not added to SUMMARY_PREFIX.md, which is added in this PR

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2021
@Ankitasw Ankitasw changed the title fix: add the new doc for using external CMM with CSI driver to summary fix: add the new doc for using external CCM with CSI driver to summary Sep 1, 2021
@Ankitasw Ankitasw changed the title fix: add the new doc for using external CCM with CSI driver to summary fix: add the doc for using external CCM with CSI driver to summary_prefix.md Sep 1, 2021
@sedefsavas
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit c43ff1a into kubernetes-sigs:main Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankitasw @sedefsavas @k8s-ci-robot