Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CAPI version to nightly 20210525 #2429

Merged
merged 1 commit into from
May 26, 2021
Merged

Update CAPI version to nightly 20210525 #2429

merged 1 commit into from
May 26, 2021

Conversation

sedefsavas
Copy link
Contributor

@sedefsavas sedefsavas commented May 25, 2021 •
edited
Loading

What this PR does / why we need it:

  • Updates CAPI nightly build for e2e tests
  • Updates e2e manifests with new MachinePool group
  • Updates cluster-api version in go.mod

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2021
@sedefsavas
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sedefsavas: The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-verify
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@sedefsavas sedefsavas mentioned this pull request May 26, 2021
Closed
Update CAPI version to nightly 20210524
b6494f9 
Change MachinePool group from exp.cluster.x-k8s.io to cluster.x-k8s.io
Change KubeadmControlplane InfrastructureTemplate to MachineTemplate

d
@sedefsavas sedefsavas changed the title Update CAPI version to nightly 20210524 Update CAPI version to nightly 20210525 May 26, 2021
@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

vincepri
vincepri approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit b8415b6 into kubernetes-sigs:main May 26, 2021
This was referenced May 26, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sedefsavas @k8s-ci-robot @vincepri