🐛fix: add more condition for resource's status filtering #2049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
[why we need it]
awscluster/awsmachine controller's code has "SetupWithManager-WithEventFilter-predicate.Funcs-UpdateFunc" to prevent incremental status updates. that code is written by
oldMachine := e.ObjectOld.(*infrav1.AWSMachine).DeepCopy()
newMachine := e.ObjectNew.(*infrav1.AWSMachine).DeepCopy()
oldMachine.Status = infrav1.AWSMachineStatus{}
newMachine.Status = infrav1.AWSMachineStatus{}
But if status updates, so does resourceVersion in metadata. Therefore, even if the status is updated, the reconciler is called.
[What this PR does]
even if the status is updated, the reconciler isn't called.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2025