Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add documentation for EKS #1894

Merged
merged 1 commit into from
Sep 1, 2020
Merged

📖 Add documentation for EKS #1894

merged 1 commit into from
Sep 1, 2020

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Aug 28, 2020

What this PR does / why we need it:
Added initial basic docs for the EKS support in the provider. This will need to be expanded over time.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1851

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Aug 28, 2020
@richardcase richardcase changed the title WIP: docs: started to add eks documentation ✨ docs: started to add eks documentation Sep 1, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2020
@randomvariable
Copy link
Member

Can you check the commit messages?

@richardcase richardcase changed the title ✨ docs: started to add eks documentation ✨ docs: add eks documentation Sep 1, 2020
Initial documentation has been added for the EKS support in the
provider. It covers how to enable the provider and the details around
the additional kubeconfig that is generated.
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 1, 2020
@richardcase
Copy link
Member Author

Can you check the commit messages?

Doh, sorry about that @randomvariable

@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6c7e3fd into kubernetes-sigs:master Sep 1, 2020
@randomvariable randomvariable changed the title ✨ docs: add eks documentation 📖 Add documentation for EKS Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for AWSManagedCluster kubeconfigs
3 participants