-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add ability to sync aws machine and node labels #1876
[WIP] Add ability to sync aws machine and node labels #1876
Conversation
Hi @alexander-demichev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@alexander-demichev: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alexander-demichev: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -181,6 +182,42 @@ func (m *MachineScope) SetAnnotation(key, value string) { | |||
m.AWSMachine.Annotations[key] = value | |||
} | |||
|
|||
// SyncMachineNodeLabel sets a key value label on the AWSMachine node. | |||
func (m *MachineScope) SyncMachineNodeLabel(ctx context.Context, remoteClient client.Client) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is SyncMachineNodeLabel
really accurate as a function name?
Looks like we only ever copy labels if they have the correct prefix. There's no ability to remove these labels.
Closing this PR in favor of kubernetes-sigs/cluster-api#3668 |
What this PR does / why we need it:
Add the ability to sync AWS machine and node labels.
I created a draft PR for so we can start the discussion about implementation details. The easiest way to sync node labels is probably to use
ClusterCacheTracker
, similar to what MHC does, get remote client, and sync all labels that start with "cluster.x-k8s.io", so users can understand where the label comes from.I'll add unit tests after we agree on implementation.