Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ refactor: cluster scope and service refactor for future EKS support #1810

Merged
merged 3 commits into from
Jul 15, 2020
Merged

✨ refactor: cluster scope and service refactor for future EKS support #1810

merged 3 commits into from
Jul 15, 2020

Conversation

richardcase
Copy link
Member

What this PR does / why we need it:
A slight refactor of the ClusterScope related stuff so that the ec2 service can be reused by the EKS implementation. Specifically in the future there will be a AWSManagedCluster\AWSManagedControlPlane.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1796

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @richardcase. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 10, 2020
@richardcase
refactor: cluster scope and service refactor for future EKS support
0cebc12 
A slight refactor of the `ClusterScope` so that the ec2 service can be
reused by the EKS implementation.

Relates To: #1796
@richardcase richardcase changed the title WIP: ✨ cluster scope and service refactor for future EKS support ✨ refactor: cluster scope and service refactor for future EKS support Jul 13, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2020
@randomvariable
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2020
vincepri
vincepri reviewed Jul 13, 2020
View reviewed changes
pkg/cloud/interfaces.go Outdated Show resolved Hide resolved
rudoi
rudoi reviewed Jul 13, 2020
View reviewed changes
pkg/cloud/interfaces.go Outdated Show resolved Hide resolved
@richardcase
refactor: fixed bad merge and added comments
d79e8b5 
Fixed an issue where the metrics change to the AWS clients had been
lost. Also added comments to the new ClusterScoper interface.

Issue: #1796
@rudoi
Copy link
Contributor

rudoi commented Jul 13, 2020

FWIW built this into an image and rolled it out to an existing self-managed cluster. Tested a handful of Machine/AWSMachine operations and saw no issues!

@detiber detiber added this to the v0.5.x milestone Jul 13, 2020
vincepri
vincepri reviewed Jul 13, 2020
View reviewed changes
pkg/cloud/interfaces.go Show resolved Hide resolved
pkg/cloud/interfaces.go Outdated Show resolved Hide resolved
@rudoi rudoi mentioned this pull request Jul 13, 2020
Merged
@richardcase
refactor: split the ClusterScoper interface and created network service
3ad5710 
The networking parts of the ec2 service have been split into a new
`network` service. As part of this the ClusterScoper interface has
been trimmed down and scopes specific to the ec2 and new network
services have been introduced.

Relates to: #1796
@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit f76ecb4 into kubernetes-sigs:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudoi rudoi rudoi left review comments

@vincepri vincepri vincepri left review comments

@randomvariable randomvariable randomvariable left review comments

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging this pull request may close these issues.

Refactor clusterscope/ec2 service
6 participants
@richardcase @k8s-ci-robot @randomvariable @rudoi @vincepri @detiber