Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Allows configuring crossZoneLoadBalancing on controlPlaneLoadBalancer #1801

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

gab-satchi
Copy link
Member

  • removed omit empty on the field so it still shows up when set to false

Fixes #1754

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from chuckha and ncdc July 8, 2020 20:26
@randomvariable
Copy link
Member

Could also a test to loadbalancer_test.go that s.configureAttributes does indeed get called when the CrossZoneLoadBalancing attribute is changed. WDYT

@randomvariable randomvariable added this to the v0.5.5 milestone Jul 9, 2020
- removed omit empty on the field so it still shows up when set to false
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2020
@gab-satchi
Copy link
Member Author

gab-satchi commented Jul 9, 2020

the configureAttributes is just a private method so testing that's called alone may not be valuable. Adding tests around ensuring the correct AWS calls are made might be better. I think AWSMachine controller tests do a decent job at that so could do something similar with cluster. Created #1804

@randomvariable
Copy link
Member

SGTM. Merging this in and treat #1804 separately.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3a98cf3 into kubernetes-sigs:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWSClusterSpec's "ControlPlaneLoadBalancer" field should be mutable
3 participants