Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TCP so that we can support different ciphers easily for v1alpha3. #1658

Closed
wants to merge 1 commit into from
Closed

Use TCP so that we can support different ciphers easily for v1alpha3. #1658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cloud/services/elb/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func (s *Service) getAPIServerClassicELBSpec() (*infrav1.ClassicELB, error) {
},
},
HealthCheck: &infrav1.ClassicELBHealthCheck{
Target: fmt.Sprintf("%v:%d", infrav1.ClassicELBProtocolSSL, 6443),
Copy link
Member

@yastij yastij Mar 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rather update the listeners/health checks to use custom order/set of SSL ciphers. If not possible, we might want to compare our list with the ELB one cc @randomvariable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as ELB goes, listeners != health checks in this regards. It is TCP passthrough for the listener. The healthcheck spec just ensures we do a TLS handshake.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that AWS only supports non-elliptic curve handshake tests for ELBv1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Target: fmt.Sprintf("%v:%d", infrav1.ClassicELBProtocolTCP, 6443),
Interval: 10 * time.Second,
Timeout: 5 * time.Second,
HealthyThreshold: 5,
Expand Down