✨ update metrics port

[cpanato]

What this PR does / why we need it:
Update metrics port based on the conversation here: #1487 (comment)

/assign @ncdc @vincepri

[k8s-ci-robot]

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato
To complete the pull request process, please assign chuckha
You can assign the PR to them by writing /assign @chuckha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncdc]

I'm not crazy about changing the metrics port. Anyone who has an existing CAPI/CAPA deployment along with some monitoring will have to reconfigure things. I think leaving it alone probably is the best thing right now. @vincepri would you agree?
/hold

[vincepri]

I know the flag to customize the metrics port came in v1alpha2, but do we expose any metrics? In other words, I'm trying to understand if the metrics endpoint has been used at all

[ncdc]

Good point. We don't have any in CAPA. There are some in CAPI, but they need refinement and are not particularly useful today.

[vincepri]

The CAPI metrics have been added in v1alpha3, we should be good updating these ports imo kubernetes-sigs/cluster-api#1736

[vincepri]

/ok-to-test

[ncdc]

@vincepri did we make a decision on this?

[vincepri]

We documented the ports here https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/reference/ports.md, we should reuse the same imo

[ncdc]

So close this?

[vincepri]

Correct, seems CAPA is already using the correct ports.

/close

[k8s-ci-robot]

@vincepri: Closed this PR.

In response to this:

Correct, seems CAPA is already using the correct ports.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.