Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Remove vendor and Bazel #1076

Merged
merged 5 commits into from
Aug 28, 2019
Merged

✨Remove vendor and Bazel #1076

merged 5 commits into from
Aug 28, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Aug 26, 2019 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1015
Fixes #970
Fixes #989

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2019
@vincepri vincepri force-pushed the remove-vendor-bazel branch from 5961f60 to 95c6060 Compare August 26, 2019 23:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2019
@vincepri vincepri force-pushed the remove-vendor-bazel branch 2 times, most recently from aad7f98 to 76aad68 Compare August 27, 2019 00:09
@vincepri
Copy link
Member Author

/assign @detiber

detiber
detiber reviewed Aug 27, 2019
View reviewed changes
Dockerfile
go build -a -ldflags '-extldflags "-static"' \
-o manager sigs.k8s.io/cluster-api-provider-aws
-o manager .

# Copy the controller-manager into a thin image
FROM gcr.io/distroless/static:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the docs here: https://github.com/GoogleContainerTools/distroless/blob/master/base/README.md#image-contents I suspect this is probably ok to support other architectures, but we should probably test to verify.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile
clusterctl: ## Build clusterctl binary.
GOFLAGS="" go build -o bin/clusterctl ./vendor/sigs.k8s.io/cluster-api/cmd/clusterctl
.PHONY: docker-build
docker-build: generate lint-full ## Build the docker image for controller-manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to build multi-arch images we need to build an image for each arch and then we need to build a manifest-list image using either docker manifest create or https://github.com/estesp/manifest-tool

scripts/ci-bazel-integration.sh Show resolved Hide resolved
scripts/ci-bazel-integration.sh Outdated Show resolved Hide resolved
scripts/ci-bazel-test.sh Outdated Show resolved Hide resolved
test/e2e/aws_test.go Show resolved Hide resolved
test/e2e/aws_test.go Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the remove-vendor-bazel branch from 76aad68 to edeb65a Compare August 27, 2019 15:14
detiber
detiber reviewed Aug 27, 2019
View reviewed changes
Makefile Show resolved Hide resolved
@vincepri vincepri force-pushed the remove-vendor-bazel branch from edeb65a to 695d35c Compare August 27, 2019 15:18
@vincepri
Copy link
Member Author

Opened kubernetes/test-infra#14085 to rename the CI jobs

@vincepri vincepri force-pushed the remove-vendor-bazel branch 2 times, most recently from 767df5f to f2f8d96 Compare August 27, 2019 15:41
detiber
detiber reviewed Aug 27, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@vincepri vincepri force-pushed the remove-vendor-bazel branch 2 times, most recently from a32ee16 to 5c1dbd0 Compare August 27, 2019 16:10
@vincepri
✨ Remove vendor
695129c
@vincepri
Update Bazel
f491b3b 
Signed-off-by: Vince Prignano <[email protected]>
@vincepri
Update generated files
e65fc5e 
Signed-off-by: Vince Prignano <[email protected]>
@vincepri
Update vendor dependencies
77dad36 
Signed-off-by: Vince Prignano <[email protected]>
@vincepri vincepri force-pushed the remove-vendor-bazel branch 4 times, most recently from 2cea9f8 to 6df8c2b Compare August 28, 2019 14:51
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Aug 28, 2019
@vincepri
Copy link
Member Author

@detiber This should be good to go, apart from the multi-arch support which we can do soon after we figure it out in CAPI :)

detiber
detiber reviewed Aug 28, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the remove-vendor-bazel branch 3 times, most recently from 32000e0 to 0dc37af Compare August 28, 2019 16:03
@vincepri vincepri force-pushed the remove-vendor-bazel branch from 0dc37af to 45d8280 Compare August 28, 2019 16:13
@detiber
Copy link
Member

detiber commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 99d7507 into kubernetes-sigs:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@vincepri @k8s-ci-robot @detiber