AWSMachine Reconciler fails with error "invalid secret backend" if insecureSkipSecretsManager: true with latest version 1.4.0

[nehatomar12]

I am using version v1.4.0
I have insecureSkipSecretsManager: true in cloudInit

as this flag is set secureSecretsBackend value is empty
due to which at the time of reconciliation flow when deleteEncryptedBootstrapDataSecret is called as this check is missing,
it goes to getSecretService, there we have a switch case for SecureSecretsBackend
as it is not set it is failing with invalid secret backend

if !machineScope.UseSecretsManager() {
		return nil
	}

Release 1.3 https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/release-1.3/controllers/awsmachine_controller.go#L579

Release 1.4
https://github.com/platform9/cluster-api-provider-aws/blob/main/controllers/awsmachine_controller.go#L628

is there any specific reason why we have removed this?

[k8s-ci-robot]

@nehatomar12: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sedefsavas]

Hi @nehatomar12, we had significant changes in v1.14.0 release to support ignition based bootstrapping.

We are already tracking this issue here:
#3394

and will make a release that will fix this soon.

[sedefsavas]

cc @invidian if you have time to review the fix for this to make sure ignition support is not affected: #3400

[sedefsavas]

/close
in favor of #3394

[k8s-ci-robot]

@sedefsavas: Closing this issue.

In response to this:

/close
in favor of #3394

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nehatomar12]

@sedefsavas Thanks
is there any documentation regarding how can I configure AWS secret manager with CAPA?

when I am using insecureSkipSecretsManager: false default AWS secret manager is used, I am getting cloudinit boot issue
Exception: [Errno 2] No such file or directory: '/etc/secret-userdata.txt' for url: file:///etc/secret-userdata.txt

in the documentation, its is mentioned that this will be warning, doc

but my cloud-init always giving error for this file