Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taints support to AWSManagedMachinePool #2399

Closed
richardcase opened this issue May 12, 2021 · 2 comments · Fixed by #2405
Closed

Add taints support to AWSManagedMachinePool #2399

richardcase opened this issue May 12, 2021 · 2 comments · Fixed by #2405
Assignees
@richardcase
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.7.0

Comments

@richardcase
Copy link
Member

/kind feature
/area provider/eks
/priority important-soon
/milestone v0.7.0
/help
/good-first-issue

Describe the solution you'd like
EKS managed nodegroups supports node taints and we should add support for this to CAPA and expose this via AWSManagedMachinePool.

Anything else you would like to add:
We need to handle this for both creation and update of a EKS node pool.

The AWS SDK will need to be updated so that the CreateNodeGroup and UpdateNodegroupConfig have the taints field available on the input

Environment:

  • Cluster-api-provider-aws version: 0.6.5
@k8s-ci-robot
Copy link
Contributor

@richardcase:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature
/area provider/eks
/priority important-soon
/milestone v0.7.0
/help
/good-first-issue

Describe the solution you'd like
EKS managed nodegroups supports node taints and we should add support for this to CAPA and expose this via AWSManagedMachinePool.

Anything else you would like to add:
We need to handle this for both creation and update of a EKS node pool.

The AWS SDK will need to be updated so that the CreateNodeGroup and UpdateNodegroupConfig have the taints field available on the input

Environment:

  • Cluster-api-provider-aws version: 0.6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone May 12, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/eks Issues or PRs related to Amazon EKS provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 12, 2021
@richardcase richardcase mentioned this issue May 13, 2021
Closed
@richardcase
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 13, 2021
@richardcase richardcase mentioned this issue May 13, 2021
Merged
1 task
@richardcase richardcase mentioned this issue Jun 1, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
area/provider/eks Issues or PRs related to Amazon EKS provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

feat: add support for taints for managed machine pools
2 participants
@richardcase @k8s-ci-robot