Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the AWSManagedControlPlane out of the main controller #1945

Closed
4 of 5 tasks
richardcase opened this issue Sep 11, 2020 · 2 comments · Fixed by #1949
Closed
4 of 5 tasks

Refactor the AWSManagedControlPlane out of the main controller #1945

richardcase opened this issue Sep 11, 2020 · 2 comments · Fixed by #1949
Assignees
@richardcase
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone
v0.6.1

Comments

@richardcase
Copy link
Member

richardcase commented Sep 11, 2020 •
edited
Loading

/kind feature

Describe the solution you'd like
Split the AWSManagedControlPlane controller (and associated functionality) out from the main manager into a separate eks control-plane manager. This is so it can be optionally installed (instead of using feature gates) via clustectl and can have separate IAM permissions.

Anything else you would like to add:
See this discussion

Tasks:

  • skaffold the new control plane project
  • move existing code across to the new project
  • update existing documents
  • update makefile targets - bundling config
  • change to clusterctl
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 11, 2020
@richardcase
Copy link
Member Author

/assign

@richardcase richardcase mentioned this issue Sep 11, 2020
Closed
@richardcase
Copy link
Member Author

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 11, 2020
@randomvariable randomvariable added this to the v0.6.1 milestone Sep 11, 2020
@richardcase richardcase mentioned this issue Sep 16, 2020
Merged
@richardcase richardcase mentioned this issue Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging a pull request may close this issue.

⚠️ refactor: split awsmanagedcontrolplane into new manager
3 participants
@richardcase @randomvariable @k8s-ci-robot