Use InstanceState instead of String in Machine Status (#577)

kubernetes-sigs · Feb 14, 2019 · d11e7ea · d11e7ea
1 parent 878bae8
commit d11e7ea
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/pkg/apis/awsprovider/v1alpha1/awsmachineproviderstatus_types.go b/pkg/apis/awsprovider/v1alpha1/awsmachineproviderstatus_types.go
@@ -35,7 +35,7 @@ type AWSMachineProviderStatus struct {
 
 	// InstanceState is the state of the AWS instance for this machine
 	// +optional
-	InstanceState *string `json:"instanceState,omitempty"`
+	InstanceState *InstanceState `json:"instanceState,omitempty"`
 
 	// Conditions is a set of conditions associated with the Machine to indicate
 	// errors or other status

diff --git a/pkg/apis/awsprovider/v1alpha1/zz_generated.deepcopy.go b/pkg/apis/awsprovider/v1alpha1/zz_generated.deepcopy.go
diff --git a/pkg/cloud/aws/actuators/machine/actuator.go b/pkg/cloud/aws/actuators/machine/actuator.go
@@ -166,7 +166,7 @@ func (a *Actuator) Create(ctx context.Context, cluster *clusterv1.Cluster, machi
 	}
 
 	scope.MachineStatus.InstanceID = &i.ID
-	scope.MachineStatus.InstanceState = aws.String(string(i.State))
+	scope.MachineStatus.InstanceState = &i.State
 
 	if machine.Annotations == nil {
 		machine.Annotations = map[string]string{}
@@ -406,6 +406,8 @@ func (a *Actuator) Exists(ctx context.Context, cluster *clusterv1.Cluster, machi
 		return false, nil
 	}
 
+	scope.MachineStatus.InstanceState = &instance.State
+
 	if err := a.reconcileLBAttachment(scope, machine, instance); err != nil {
 		return true, err
 	}