Skip to content

Commit

Permalink
chore: incorporating review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
richardcase committed Dec 1, 2020
1 parent 07601c3 commit 1b21f3e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/adr/0003-separate-e2e-packages.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@

## Context

The e2e tests for CAPA where initially in a single package and this package contained functional e2e and conformance tests for the unmanaged (i.e. purely EC2 with CAPBK) side of the provider.
The e2e tests for CAPA where initially in a single package and this package contained functional e2e and conformance tests for the unmanaged (i.e. purely EC2 with CABPK) side of the provider.

With the addition of the EKS functionality to CAPA new e2e tests ([#1907](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/1907)) are required and we need the ability to maintain and run e2e tests for the different parts of the provider separately.

## Decision

The e2e tests will be split into separate packages that will represent a distinct suite of e2e tests with accompying targets to enable running each suite. To reduce code duplication there will also be a shared e2e package that will contain functionality that is common to all the test package suites.
The e2e tests will be split into separate packages that will represent a distinct suite of e2e tests with accompanying targets to enable running each suite. To reduce code duplication there will also be a shared e2e package that will contain functionality that is common to all the test package suites.

## Consequences

Expand Down

0 comments on commit 1b21f3e

Please sign in to comment.