✨ Pass image overrides to in-memory client #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/M
Danil-Grigorev
force-pushed
the
clusterctl-image-overrides
branch
from
96ea095 to
dbd65c3
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Danil-Grigorev
force-pushed
the
clusterctl-image-overrides
branch
2 times, most recently
from
6d7ea16 to
f0e66c3
Compare
- Add tests verifying functionality of overrides client for image or provider URL resolve Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
clusterctl-image-overrides
branch
from
f0e66c3 to
0745be4
Compare
Danil-Grigorev
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
furkatgofurov7
approved these changes
Sep 3, 2024
|
|
||
| if p.overridesClient != nil { | ||
| providers, err := p.overridesClient.Providers().List() | ||
| if err != nil { |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9be3b8eeee41210c017631b98234bf92b0c85033
|
hardys
added a commit
to hardys/charts
that referenced
this pull request
Sep 3, 2024
The current clusterctl override is not working ref this fix: kubernetes-sigs/cluster-api-operator#598
hardys
added a commit
to hardys/charts
that referenced
this pull request
Sep 3, 2024
The current clusterctl override is not working ref this fix: kubernetes-sigs/cluster-api-operator#598
hardys
added a commit
to suse-edge/charts
that referenced
this pull request
Sep 4, 2024
The current clusterctl override is not working ref this fix: kubernetes-sigs/cluster-api-operator#598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change allows to pass
imagesvariable overrides to a localclusterctl.yamlfile, allowing a granular control on default image sources for the provider installations.Added tests for existing overrides functionality.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #