✨ Add featureGates to ControlPlaneProvider

[kahirokunn]

What this PR does / why we need it:

This PR adds support for specifying featureGates in the ControlPlaneProvider. This is particularly necessary when using infrastructure=docker, as we need to pass CLUSTER_TOPOLOGY=true to the kubeadm provider. Currently, there is no way to do this, and this feature is essential for enabling cluster topology features in kubeadm.

Usage Example:

To use this feature, you can install the capi-operator with Helm and specify the feature gates in your values file. Here is an example:

helm install capi-operator cluster-api-operator/cluster-api-operator --version 0.10.1 -n capi-operator-system --create-namespace --values ./example-values.yaml

example-values.yaml:

cert-manager:
  enabled: false
  installCRDs: false
infrastructure: docker:v1.7.2
core: cluster-api:v1.7.2
controlPlane: kubeadm:v1.7.2
manager:
  featureGates:
    core:
      ClusterTopology: true
      MachinePool: true
    docker:
      ClusterTopology: true
      MachinePool: true
    kubeadm:
      ClusterTopology: true
      MachinePool: true

Sample Output:

Here is a portion of the expanded manifest showing the applied feature gates:

# Source: cluster-api-operator/templates/control-plane.yaml
apiVersion: operator.cluster.x-k8s.io/v1alpha2
kind: ControlPlaneProvider
metadata:
  name: kubeadm
  namespace: kubeadm-control-plane-system
  annotations:
    "helm.sh/hook": "post-install"
    "helm.sh/hook-weight": "2"
spec:
  version: v1.7.2
  manager:
    featureGates:
      ClusterTopology: true
      MachinePool: true

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Welcome @kahirokunn!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kahirokunn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name	Link
🔨 Latest commit	80c8b64
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/674d4e5e5c76090008cc4b26
😎 Deploy Preview	https://deploy-preview-536--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alexander-demicev]

thanks a lot for this PR, can I you to add tests here https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/helm_test.go?

[alexander-demicev]

/ok-to-test

[furkatgofurov7]

/retest

[furkatgofurov7]

LGTM, but CI was not agreeing with me. Let's wait if retrigger helps (assuming it was a CI flake).

[furkatgofurov7]

LGTM, but CI was not agreeing with me. Let's wait if retrigger helps (assuming it was a CI flake).

We would need to check in template if feature gates are set before trying to access them, so that tests won't fail

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[furkatgofurov7]

/remove-lifecycle stale

[furkatgofurov7]

@kahirokunn can you rebase on top of the main and look at the CI failure? This is almost ready to take in IMO

[kahirokunn]

@furkatgofurov7 I fixed it by checking for the existence of the value so that the nil pointer exception would not occur.
I'd be happy if we could merge!

[furkatgofurov7]

@kahirokunn this looks good already, the only pending comment that needs addressing is #536 (review)

[kahirokunn]

@furkatgofurov7
I have resolved the comment as the content has already been addressed.
Would this be acceptable to you?

[furkatgofurov7]

https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/helm_test.go

@kahirokunn maybe you missed it, but what I was referring to miss in this patch seems to be updating a tests in https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/helm_test.go as per review comment

[kahirokunn]

I understand.
I'll add it.

[kahirokunn]

@furkatgofurov7 Thank you for pointing that out! I’ve written the necessary test and updated the file at test/e2e/helm_test.go as per the review comment. Please let me know if there’s anything else that needs to be addressed.

[Danil-Grigorev]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: abe7e21f9b57fcce28f94f971269939c07dd74c8

[furkatgofurov7]

@furkatgofurov7 Thank you for pointing that out! I’ve written the necessary test and updated the file at test/e2e/helm_test.go as per the review comment. Please let me know if there’s anything else that needs to be addressed.

Thanks for your patience and work on this PR, and sorry for late reply (I was on PTO), this looks good to me.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [furkatgofurov7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kahirokunn]

Thxs!