Gateway can be omitted from pool spec #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, might have been the wrong order to merge these... Could you rebase this one please? |
This change allows the Gateway to be omitted from the Pool, preventing an error. Also, prior to this change, Gateway was required when specifying `pool.spec.addresses`. We took this opportunity to move what we considered business logic out of the pool utility package, and brought it back closer to the other business logic in the controller. The gateway is conditionally added to the list of in use IPs in the controller. fixes: kubernetes-sigs#89 Signed-off-by: Tyler Schultz <[email protected]> Co-authored-by: Aidan Obley <[email protected]> Co-authored-by: Edwin Xie <[email protected]>
flawedmatrix
force-pushed
the
optional-gateway
branch
from
cda5bba to
e6d192f
Compare
|
We expected a conflict, NP. Rebased, should be good now. |
schrej
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Gateway to be omitted from the Pool, preventing an error. Also, prior to this change, Gateway was required when specifying
pool.spec.addresses. This change makes gateway optional when specifyingpool.spec.addresses.We took this opportunity to move what we considered business logic out of the pool utility package, and brought it back closer to the other business logic in the controller. The gateway is conditionally added to the list of in use IPs in the controller.
fixes: #89