-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix image reference in tilt-provider.yaml #273
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @erwin-kok! |
It is. I had this changed locally already but apparently forgot to commit and push it as well... You'll need to sign the CLA for me to be able to merge this. If you don't want to bother I can also fix it myself. |
Thanks @schrej! Please give me some time to sign the CLA (I was not aware of this). I don't want to get trouble with my employer (I want to contribute on a personal basis). I will come back to this asap. |
Hi @schrej , the CLA is covered now! Can you have another look? |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erwin-kok, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While testing cluster-api-proxmox (which has tilt reference to this project), I found that tilt was not able to build this provider. Digging into it I found that the image reference was changed from "telekom" to "k8s-staging-capi-ipam-ic". However, this reference was not updated. @schrej can you perhaps acknowledge that this is the correct fix?