Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix image reference in tilt-provider.yaml #273

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

erwin-kok
Copy link
Contributor

  • This is a small fix to be able to use tilt in other project referring to this project.

While testing cluster-api-proxmox (which has tilt reference to this project), I found that tilt was not able to build this provider. Digging into it I found that the image reference was changed from "telekom" to "k8s-staging-capi-ipam-ic". However, this reference was not updated. @schrej can you perhaps acknowledge that this is the correct fix?

Copy link

linux-foundation-easycla bot commented Aug 16, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from schrej and srm09 August 16, 2024 08:08
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 16, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @erwin-kok!

It looks like this is your first PR to kubernetes-sigs/cluster-api-ipam-provider-in-cluster 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-ipam-provider-in-cluster has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2024
@schrej
Copy link
Member

schrej commented Aug 16, 2024

It is. I had this changed locally already but apparently forgot to commit and push it as well...

You'll need to sign the CLA for me to be able to merge this. If you don't want to bother I can also fix it myself.

@erwin-kok
Copy link
Contributor Author

It is. I had this changed locally already but apparently forgot to commit and push it as well...

You'll need to sign the CLA for me to be able to merge this. If you don't want to bother I can also fix it myself.

Thanks @schrej!

Please give me some time to sign the CLA (I was not aware of this). I don't want to get trouble with my employer (I want to contribute on a personal basis). I will come back to this asap.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2024
@erwin-kok
Copy link
Contributor Author

Hi @schrej , the CLA is covered now! Can you have another look?

@schrej
Copy link
Member

schrej commented Aug 22, 2024

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erwin-kok, schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 27dc07b into kubernetes-sigs:main Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants