Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ align prefix of deployments with image name #214

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

schrej
Copy link
Member

@schrej schrej commented Dec 7, 2023

What this PR does / why we need it:
Replaces the caip-in-cluster prefix with capi-ipam-in-cluster to be in line with the future image name. It was pointed out that caip just looks like a misspelling of capi.

I think this will lead to issues when upgrading existing deployments with clusterctl and would require to manually uninstall the provider first.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from srm09 December 7, 2023 11:31
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
@schrej schrej added this to the v1.0.0 milestone Dec 7, 2023
@rikatz
Copy link
Contributor

rikatz commented Feb 2, 2024

/lgtm
/hold

Unhold as you wish :)

Gave a headsup on it for my colleagues as well! Thanks!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@schrej
Copy link
Member Author

schrej commented Feb 2, 2024

Thanks. Then we'll just have to remember putting this into release notes. Should only require a manual removal of the old resources. Since CRDs can stay, no data should be lost.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 394590f into main Feb 2, 2024
8 checks passed
@agtogna
Copy link
Contributor

agtogna commented Feb 12, 2024

[...] Should only require a manual removal of the old resources. Since CRDs can stay, no data should be lost.

I desume it can't be upgraded via clusterctl. What is the correct way to upgrade then?
Could we completely remove the "old" caip-in-cluster-system namespace and then upgrade the IPAM component via clusterctl? e.g.

kubectl delete namespace caip-in-cluster-system
clusterctl upgrade apply --ipam incluster:v0.1.0-rc.0

@schrej
Copy link
Member Author

schrej commented Feb 12, 2024

Yeah, that should work. I haven't tested it though.

@agtogna
Copy link
Contributor

agtogna commented Apr 10, 2024

the correct way to do it is:

kubectl delete namespace caip-in-cluster-system
clusterctl init --ipam incluster:v0.1.0 --config clusterctl-IPAM.config.yaml

where clusterctl-IPAM.config.yaml is:

---
providers:
  - name: incluster
    url: https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster/releases/latest/ipam-components.yaml
    type: IPAMProvider

@schrej
Copy link
Member Author

schrej commented Apr 15, 2024

clusterctl v1.7 should no longer require the extra configuraiton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants