-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ align prefix of deployments with image name #214
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Unhold as you wish :) Gave a headsup on it for my colleagues as well! Thanks! |
Thanks. Then we'll just have to remember putting this into release notes. Should only require a manual removal of the old resources. Since CRDs can stay, no data should be lost. /unhold |
I desume it can't be upgraded via kubectl delete namespace caip-in-cluster-system
clusterctl upgrade apply --ipam incluster:v0.1.0-rc.0 |
Yeah, that should work. I haven't tested it though. |
the correct way to do it is: kubectl delete namespace caip-in-cluster-system
clusterctl init --ipam incluster:v0.1.0 --config clusterctl-IPAM.config.yaml where clusterctl-IPAM.config.yaml is: ---
providers:
- name: incluster
url: https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster/releases/latest/ipam-components.yaml
type: IPAMProvider |
|
What this PR does / why we need it:
Replaces the
caip-in-cluster
prefix withcapi-ipam-in-cluster
to be in line with the future image name. It was pointed out that caip just looks like a misspelling of capi.I think this will lead to issues when upgrading existing deployments with clusterctl and would require to manually uninstall the provider first.