fix: get vmss instance error for standalone vm #798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
nilo19
reviewed
Sep 7, 2021
| @@ -142,6 +142,13 @@ func (c *controllerCommon) getNodeVMSet(nodeName types.NodeName, crt azcache.Azu | |||
| } | |||
|
|
|||
| // 4. Node is managed by vmss | |||
| if _, err := ss.GetInstanceIDByNodeName(mapNodeNameToVMName(nodeName)); err != nil { | |||
There was a problem hiding this comment.
We should invoke vmas.GetInstanceIDByNodeName in ss.GetInstanceIDByNodeName instead of modifying the vmSet directly. This is because it is recommended to set the vmSet type to vmss when using standalone VMs.
|
it actually works on capz standalone vm node pool now, should set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: get vmss instance error for standalone vm
This PR fixed the issue when agent node is either not vmss nor in availability set, in such case, should return
standardvmType when attach/detach disk. Original error is like following on capz cluster:Which issue(s) this PR fixes:
Fixes #338, #576
Special notes for your reviewer:
/hold
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: